From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752029AbbJWNHw (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Oct 2015 09:07:52 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:56547 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751294AbbJWNHv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Oct 2015 09:07:51 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Eric Auger <eric.auger@linaro.org>, eric.auger@st.com,
        alex.williamson@redhat.com, b.reynal@virtualopensystems.com,
        kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, christoffer.dall@linaro.org,
        patches@linaro.org
Subject: Re: [PATCH v3 2/7] vfio: platform: add capability to register a reset function
Date: Fri, 23 Oct 2015 15:07:37 +0200
Message-ID: <5723752.hDK15zeNcm@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1445603835-14506-3-git-send-email-eric.auger@linaro.org>
References: <1445603835-14506-1-git-send-email-eric.auger@linaro.org> <1445603835-14506-3-git-send-email-eric.auger@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:JjDOELaSES0mV5Xyf2uDCNzAdR9spw6BR4Dm3kdtShcMA4/UM+0
 ycT+ALF1xzq+Z/05ORdK5IqXorpOk8/CEIZ9YTjdW3yoSAaZLeBqjs9/hHy62a5iuaU0C7a
 OqcXS5pl84CnntWqN6K2hKkPibNg8jjQLs8QVMEAOqEqgCRXHQbjBH1v1p3c2x4eCSvD9aw
 PcbN3lUZHuFx48F2OYGGw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:UHQwKLDYchM=:OkOgON8b5TMfdsif/31INH
 1rk0yBv//8n1gKhRw7fZXbSDYV1sTOWtn4BiKnFaiP3R9gu+aeQsC78vH2VPieZM21IpqRXly
 xejGOWrLhBwbSDlvdwAQi1zf5y1rssw9KTscT5uS3e2/nldr3sl9mP4K1AdItrnKXeF0pis6l
 E0AmFDEyHvIp2W+ppNr8rNfzl9DFW6Ek8Mboz0gkJTvf7AbdZEOpxTNgIm7UVx5XpdCNgaMSS
 M03mWU2isWLPPKp4MraJYjqH65p18YpKk1sHh/Ry09ba5tVWi29phr47UrN13LZK53QmGGQ/7
 FoOr3iYyLu1gg01CjKLiaSfe00kgfeuvhCRINhf1GSe1T7OFFL1PIHIOVrmcgn77g+MvFFu6V
 FCc9DdZAk3hm9upnKbBbuGV+xPlrHX3YZDwL2HWNR4vN8+UVlHdAY6bIhNVR7178tkQGD9taV
 jwHDHhZP1rjJcB2nKMxOkvgy8o/PMVt849SuIms03m/FY4V+w4TvCCTn0V+4LS0hzFgdS4rAF
 q5aE4nIamQy3cOkiQZiCuk9qxiOxFYbjNjdWL3bJFxvlfidzeIsYeWA1RcT/JxJLh5/F/0HKQ
 VmdkJZqQJza5UoQ5Kd/UCPr3SRewjY/zEpUQgctOffbSldpjvvbyZVIB6ci8P/IJqL34APr1B
 4pXKI9CyaDy35bZ5hU9UQDk/S8zO/I62mVHT/agXbyZsqY2d7OeuRuCa1DLSiJbB3odDzF0sn
 KE1801pUDsS3D7yg
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 23 October 2015 14:37:10 Eric Auger wrote:
> +
> +void vfio_platform_unregister_reset(const char *compat)
> +{
> +       struct vfio_platform_reset_node *iter, *temp;
> +
> +       mutex_lock(&driver_lock);
> +       list_for_each_entry_safe(iter, temp, &reset_list, link) {
> +               if (!strcmp(iter->compat, compat)) {
> +                       list_del(&iter->link);
> +                       break;
> +               }
> +       }
> +
> +       mutex_unlock(&driver_lock);
> +}
> +EXPORT_SYMBOL_GPL(vfio_platform_unregister_reset);
> 

This is slightly unsafe in case you ever get two drivers that register
with the same compat string. If we care about that, we could pass
and compare both the string and the function pointer, or the
vfio_platform_reset_node.

	Arnd