From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E58CC1FC7C3 for ; Wed, 8 Jan 2025 13:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736343602; cv=none; b=cHF7LAaC6Oo7O0fIVJ5epFs5YUlo6ZVmLsroyBTYGvE2keTecHH/tlx8abhaSRW75y1W6MYtvEt3RPSeOG9CH6xgiXpFubTVNnj2Ule+vfR1Sk1a7CSPKSxRNh/bmub5dsuwaNpETYx7VwOABugbIftYaSGAiwJvzIRbGo1n+zU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736343602; c=relaxed/simple; bh=s0T7t0j/LLuM4MOeiRujtOZrsXZ5iu7HXSVb6itsodk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E1FRVVUnivA123n7aZ1P0wfL9cGCpFEnv8GXCDv2Ed8Db4j8svaj70xakOGH+KgxBIKdNFDPAfrXrda+7Yj4iH9ktrdBgwvds66CblYN1qpeSYp2iGegSN2jS92EL4JGNsoBPh+bEsIp61tfoBAN5GWj5ePzZ7Qg5B3lLa6Oe/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HKQOVi/h; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HKQOVi/h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736343599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L9dShwzXz8XQGaRK00dhQCGVPSnhp0XqFOSWCYn++c8=; b=HKQOVi/h/MoFd9c7g+NuzHH2NudFNm7jOvGCOaxP8Pu5owqlFSVEbR3eEE6Ux352b4zdhY RY8C4+x4QYOAB5gVcFlk7ocWx84o64C7yae3hl4T2pLOlaguy6yFLrsnED/O3lpPPlLlOp d5kdmdPlyVmLTSZFWB4DAjhmpYNjGMo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-cpQ1NVJ9MRKpUW7IQHwaww-1; Wed, 08 Jan 2025 08:39:58 -0500 X-MC-Unique: cpQ1NVJ9MRKpUW7IQHwaww-1 X-Mimecast-MFC-AGG-ID: cpQ1NVJ9MRKpUW7IQHwaww Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43626224274so53909005e9.0 for ; Wed, 08 Jan 2025 05:39:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736343597; x=1736948397; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L9dShwzXz8XQGaRK00dhQCGVPSnhp0XqFOSWCYn++c8=; b=o1si27tMdOIhQnq4JQ4nhUHhzQ2MDSvViauDjcXJXrcM6Ut0QTUJzFFuhlrvvBOOAF YssO6BupDtflRKubsue8Q5CX/Ad65lQxAAjJLu1wDxaIFTk1WP7riVBs7VVp93NntEyw oDSWPKHDQaE64cSiXKugOxkZxGm6Ju3u1V3K4Okbh2Qj2iA+Wh5XTxrVE2vvEjuGNf+M lMnelh5ljMLIT0TCmB0rbPJqhwPp3k0RKEw1r6Bu8XtAw69B8NzcWndfbj8yqz5bERCD GO3jBJRLqGkNy3yVugNVkfo6ujPt8Flf/mMbjD9N6Vdfp7EfZYT+mCx44WilCLrX7Q6v 4bHQ== X-Gm-Message-State: AOJu0Yz2rPa45VhlKwa7n8eZsl9uoyuZ76anUhao6fyz1Hpm2WTcGmNy +ToEwmLAvawTcjNaXxzekTtKcmUW9YxFPmhDSuO5OSwN/xuR3PLsldg179dk402qDM4pGVoQ0dg Ir+6boxJP1xh3ybla5vuu1tWUstZ+Nvj0AN2QinStMC7kdQqZagCWJi4SyEPptA== X-Gm-Gg: ASbGncvhVbD4fFrgKjK26G8BazOJ/Vq0T/15R9Xv5IevGT5gX3aHGVY+tWUoQ1nRJ8r QWS7iRiYVN9YP0j+399JPlcH8R/d5oB7HxT/gwdVWfr15OurTecAqmYd21trToJlXNqXm++84wS nsYka7UP5RMCuQRSoAtoBKm61a1sDR7tUiKq1l9uEaj6JH/0JQaVpT3zWr0Hya0dgVLnf0emutL rlX0SEU/wqyZmNAq49cxlZlEUtezqCE6ctNBlGDUKiuv3srEDX0cmFiU6FNKdmpo7pObgGn0tsH LQzwU1yfrLCw1dOnLONIJBUw2zSg5muiDG0itx12Jt6VyKiMPFCIGpy8g1qawbVj7rW1PS8mWjv DHg4xmw== X-Received: by 2002:a05:600c:5491:b0:434:f7f0:1880 with SMTP id 5b1f17b1804b1-436e26ec32amr20972915e9.32.1736343597085; Wed, 08 Jan 2025 05:39:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGy83iYk7DTo544kiOng8vFAJKXlDHS+D4knnr9So5Cgsg5UPbZHXaVFQqQbe8WvFUpy7r+gA== X-Received: by 2002:a05:600c:5491:b0:434:f7f0:1880 with SMTP id 5b1f17b1804b1-436e26ec32amr20972765e9.32.1736343596731; Wed, 08 Jan 2025 05:39:56 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7? (p200300cbc70d3a00d73c06a8ca9f1df7.dip0.t-ipconnect.de. [2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8add5asm52229612f8f.107.2025.01.08.05.39.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 05:39:55 -0800 (PST) Message-ID: <5724ae77-0863-4f8a-90ad-ebe2d2268eb1@redhat.com> Date: Wed, 8 Jan 2025 14:39:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: alloc_pages_bulk_noprof: drop page_list argument To: Luiz Capitulino , linux-mm@kvack.org, mgorman@techsingularity.net, willy@infradead.org Cc: linux-kernel@vger.kernel.org, lcapitulino@gmail.com References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.12.24 23:00, Luiz Capitulino wrote: > The commit 387ba26fb1cb ("mm/page_alloc: add a bulk page allocator") added > __alloc_pages_bulk() along with the page_list argument. The next > commit 0f87d9d30f21 ("mm/page_alloc: add an array-based interface to the > bulk page allocator") added the array-based argument. As it turns out, the > page_list argument has no users in the current tree (if it ever had any). > Dropping it allows for a slight simplification and eliminates some > unnecessary checks, now that page_array is required. > > Also, note that the removal of the page_list argument was proposed before > in the thread below, where Matthew Wilcox mentions that: > > """ > Iterating a linked list is _expensive_. It is about 10x quicker to > iterate an array than a linked list. > """ > (https://lore.kernel.org/linux-mm/20231025093254.xvomlctwhcuerzky@techsingularity.net) > > Signed-off-by: Luiz Capitulino > --- Acked-by: David Hildenbrand Thanks! -- Cheers, David / dhildenb