From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbcEBBFz (ORCPT ); Sun, 1 May 2016 21:05:55 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33050 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbcEBBFs (ORCPT ); Sun, 1 May 2016 21:05:48 -0400 Subject: Re: [RFC 1/5] powerpc: Rename context.vdso_base to context.vdso To: Christopher Covington , Catalin Marinas , criu@openvz.org, Laurent Dufour , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <20151202121918.GA4523@arm.com> <1461856737-17071-1-git-send-email-cov@codeaurora.org> <1461856737-17071-2-git-send-email-cov@codeaurora.org> From: Balbir Singh Message-ID: <5726A7D5.7030305@gmail.com> Date: Mon, 2 May 2016 11:05:25 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461856737-17071-2-git-send-email-cov@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/04/16 01:18, Christopher Covington wrote: > In order to share remap and unmap support for the VDSO with other > architectures without duplicating the code, we need a common name and type > for the address of the VDSO. An informal survey of the architectures > indicates unsigned long vdso is popular. Change the variable name in > powerpc from mm->context.vdso_base to simply mm->context.vdso. > Could you please provide additional details on why the remap/unmap operations are required? This patch does rename, but should it abstract via a function acesss to vmap field using arch_* operations? Not sure Balbir Singh