From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135AbcEFGJo (ORCPT ); Fri, 6 May 2016 02:09:44 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:36487 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbcEFGJm (ORCPT ); Fri, 6 May 2016 02:09:42 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: <0fd93c6fdda33aa8d20d60a60bd6fdc2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v7 7/9] dt-bindings: i2c: rk3x: add support for rk3399 To: Rob Herring References: <1462371194-5809-1-git-send-email-david.wu@rock-chips.com> <1462372523-6444-1-git-send-email-david.wu@rock-chips.com> <20160505221212.GA26820@rob-hp-laptop> Cc: heiko@sntech.de, wsa@the-dreams.de, dianders@chromium.org, andy.shevchenko@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, briannorris@google.com, davidriley@google.com, huangtao@rock-chips.com, hl@rock-chips.com, xjq@rock-chips.com, zyw@rock-chips.com, cf@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: "David.Wu" Message-ID: <572C352C.50303@rock-chips.com> Date: Fri, 6 May 2016 14:09:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160505221212.GA26820@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, 在 2016/5/6 6:12, Rob Herring 写道: > On Wed, May 04, 2016 at 10:35:23PM +0800, David Wu wrote: >> The bus clock and function clock are separated at rk3399, >> and others use one clock as the bus clock and function clock. >> >> Signed-off-by: David Wu >> --- >> Documentation/devicetree/bindings/i2c/i2c-rk3x.txt | 16 +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt b/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt >> index 0b4a85f..82b6f6b 100644 >> --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt >> +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.txt >> @@ -6,10 +6,20 @@ RK3xxx SoCs. >> Required properties : >> >> - reg : Offset and length of the register set for the device >> - - compatible : should be "rockchip,rk3066-i2c", "rockchip,rk3188-i2c", >> - "rockchip,rk3228-i2c" or "rockchip,rk3288-i2c". >> + - compatible: should be one of the followings > > s/followings/following:/ > >> + - "rockchip,rk3066-i2c": for rk3066 >> + - "rockchip,rk3188-i2c": for rk3188 >> + - "rockchip,rk3228-i2c": for rk3228 >> + - "rockchip,rk3288-i2c": for rk3288 >> + - "rockchip,rk3399-i2c": for rk3399 >> - interrupts : interrupt number >> - - clocks : parent clock >> + - clocks: See ../clock/clock-bindings.txt >> + - For older hardware (rk3066, rk3188, rk3228, rk3288): >> + - There is one clock that's used both to derive the functional clock >> + for the device and as the bus clock. REQUIRED. > > This is the required section, so REQUIRED is redundant. > >> + - For newer hardware (rk3399): specify by name >> + - "i2c": REQUIRED. This is used to derive the functional clock. >> + - "pclk": REQUIRED. This is the bus clock.equired on RK3066, RK3188 : > > This doesn't make sense. The first line says this applies to rk3399, but > then here it is talking about other parts. > > And there's a typo. > Okay, I will remove the "equired on RK3066, RK3188 :". >> >> Required on RK3066, RK3188 : >> >> -- >> 1.9.1 >> >> > > >