From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757874AbcEFG1n (ORCPT ); Fri, 6 May 2016 02:27:43 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:53538 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbcEFG1l (ORCPT ); Fri, 6 May 2016 02:27:41 -0400 X-AuditID: cbfec7f5-f792a6d000001302-f5-572c39591641 Subject: Re: [RFC v2 11/13] usb: port: Parse pwrseq phandle from Device Tree To: Javier Martinez Canillas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-12-git-send-email-k.kozlowski@samsung.com> Cc: tjakobi@math.uni-bielefeld.de, m.szyprowski@samsung.com, hverkuil@xs4all.nl, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <572C3957.3010503@samsung.com> Date: Fri, 06 May 2016 08:27:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xa7qRljrhBpfus1tsnLGe1WLqwyds FpOevGe2mH/kHKvFxJWTmS2aF69nszg1+RmTxZu3a5gsXr8wtNj0+BqrxeVdc9gsjvzvZ7T4 3HuE0WLG+X1MFouWtTJbrD1yl93i9O4Si7bVH1gtjq8NdxD22DnrLrvH5hVaHptWdbJ53Lm2 h81j/9w1QKEl9R7/jrF7bOkHyvdtWcXo8XmTnMepr5/ZA7ijuGxSUnMyy1KL9O0SuDKaDrkX 9HFV/Jj9g62BsYmji5GTQ0LAROLR0ytsELaYxIV764FsLg4hgaWMEg/u/2ECSQgJPGOU2LK4 EMQWFvCR2NKwCqxIRKCXReLCufNMEB37GSU2TlwNlmEWaGeU2HpqN9hcNgFjic3Ll4DZvAJa Euc+LWAGsVkEVCX2NfSzgtiiAhESq9ddY4aoEZT4MfkeC4jNKeAs8ffAOcYuRg6goXoS9y9q gYSZBeQlNq95yzyBUWAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRES jV93MC49ZnWIUYCDUYmHN+OkdrgQa2JZcWXuIUYJDmYlEV5VM51wId6UxMqq1KL8+KLSnNTi Q4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBKAcP5hGFu0fnyxncJtw+vtuWd5OHLynKw KmDObnHZB1JMNafvGoY1G/zhWTT12zWtH0nJdn7553gPnvp0Wyi0/sn51NWGG1zut646xqz4 k+uWzvJIndsXmI+eN7/EzHp39Qynyq3M8SE1X1a4n/3FkCDmfkvB6qG2v1NzTeLKI//3nV3Q ac2uoKDEUpyRaKjFXFScCABhMn6cwgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2016 10:10 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq >> device. The pwrseq device will be used by USB hub to cycle the power >> before activating ports. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> >> @@ -532,6 +534,14 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1) >> return retval; >> } >> >> + port_dev->dev.of_node = usb_of_get_child_node(hub->hdev->dev.of_node, port1); >> + port_dev->pwrseq = pwrseq_alloc(&port_dev->dev); >> + if (IS_ERR(port_dev->pwrseq)) { >> + device_unregister(&port_dev->dev); >> + /* TODO: what about EPROBE_DEFER? */ > > I think it's OK since the call chain is: > > hub_probe() > hub_configure() > usb_hub_create_port_device() > > so the hub_probe() will be deferred if the usb-pwrseq was not registered yet. > Unless I misunderstood your question :) > > Anyway, patch looks good to me: > > Reviewed-by: Javier Martinez Canillas Yes and deferred probing works in my case. That is an older comment actually. Thanks for review, Krzysztof