From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759156AbcEGCXF (ORCPT ); Fri, 6 May 2016 22:23:05 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:57797 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758997AbcEGCXB (ORCPT ); Fri, 6 May 2016 22:23:01 -0400 Subject: Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure To: Dan Williams , linux-nvdimm@ml01.01.org References: <146255559866.32780.5399379827409805110.stgit@dwillia2-desk3.amr.corp.intel.com> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Guenter Roeck Message-ID: <572D5182.9090808@roeck-us.net> Date: Fri, 6 May 2016 19:22:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <146255559866.32780.5399379827409805110.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 10:26 AM, Dan Williams wrote: > I had relied on the kbuild robot for cross build coverage, however it > only builds alpha_defconfig. Switch from HPAGE_SIZE to PMD_SIZE, which > is more widely defined. > > Fixes: 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing") > Cc: > Reported-by: Guenter Roeck > Signed-off-by: Dan Williams Passes at least all my tests. Tested-by: Guenter Roeck Nitpick below. > --- > drivers/nvdimm/pmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 5101f3ab4f29..e5a8bf032ec9 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -404,7 +404,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn) > * vmemmap_populate_hugepages() allocates the memmap array in > * HPAGE_SIZE chunks. PMD_SIZE > */ > - memmap_size = ALIGN(64 * npfns, HPAGE_SIZE); > + memmap_size = ALIGN(64 * npfns, PMD_SIZE); > offset = ALIGN(start + SZ_8K + memmap_size, nd_pfn->align) > - start; > } else if (nd_pfn->mode == PFN_MODE_RAM) > >