From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbcEIJqM (ORCPT ); Mon, 9 May 2016 05:46:12 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:54565 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbcEIJqK (ORCPT ); Mon, 9 May 2016 05:46:10 -0400 Subject: Re: [PATCH v7 03/14] usb: hcd.h: Add OTG to HCD interface To: Peter Chen References: <1462191537-10314-1-git-send-email-rogerq@ti.com> <1462191537-10314-4-git-send-email-rogerq@ti.com> <20160506094103.GF32359@shlinux2.ap.freescale.net> CC: , , , , , , , , , , , , , , From: Roger Quadros Message-ID: <57305C42.90300@ti.com> Date: Mon, 9 May 2016 12:45:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160506094103.GF32359@shlinux2.ap.freescale.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/16 12:41, Peter Chen wrote: > On Mon, May 02, 2016 at 03:18:46PM +0300, Roger Quadros wrote: >> The OTG core will use struct otg_hcd_ops to interface >> with the HCD controller. >> >> The main purpose of this interface is to avoid directly >> calling HCD APIs from the OTG core as they >> wouldn't be defined in the built-in symbol table if >> CONFIG_USB is m. >> >> Signed-off-by: Roger Quadros >> Acked-by: Peter Chen > > Roger, after thinking more, I still think current dependency between > OTG, HCD and gadget are too complicated. Since the OTG can't work > if it is built as module, I suggest letting OTG depends on HCD && > USB_GADGET, and it is a boolean, in that case, we don't need to > export any HCD and gadget ops, things will be much simpler. > What's your opinion? How will it work if HCD and USB_GADGET are modules and OTG is built-in? cheers, -roger > > Peter > >> --- >> include/linux/usb/hcd.h | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h >> index b98f831..861ccaa 100644 >> --- a/include/linux/usb/hcd.h >> +++ b/include/linux/usb/hcd.h >> @@ -399,6 +399,30 @@ struct hc_driver { >> >> }; >> >> +/** >> + * struct otg_hcd_ops - Interface between OTG core and HCD >> + * >> + * Provided by the HCD core to allow the OTG core to interface with the HCD >> + * >> + * @add: function to add the HCD >> + * @remove: function to remove the HCD >> + * @usb_bus_start_enum: function to immediately start bus enumeration >> + * @usb_control_msg: function to build and send of a control urb >> + * @usb_hub_find_child: function to get pointer to the child device >> + */ >> +struct otg_hcd_ops { >> + int (*add)(struct usb_hcd *hcd, >> + unsigned int irqnum, unsigned long irqflags); >> + void (*remove)(struct usb_hcd *hcd); >> + int (*usb_bus_start_enum)(struct usb_bus *bus, unsigned int port_num); >> + int (*usb_control_msg)(struct usb_device *dev, unsigned int pipe, >> + __u8 request, __u8 requesttype, __u16 value, >> + __u16 index, void *data, __u16 size, >> + int timeout); >> + struct usb_device * (*usb_hub_find_child)(struct usb_device *hdev, >> + int port1); >> +}; >> + >> static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd) >> { >> return hcd->driver->flags & HCD_BH; >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >