From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760D619DFB4 for ; Mon, 23 Dec 2024 12:43:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734957830; cv=none; b=SodYLTk/H25ilTRxJ14pIhxgsEUUjMb3j8JMDDPTGlAhPl4UShWZLi0wh6nkSPzIP7s9+DQU8w32L6igYVUuB3Vsa2xTcbX9cp74a6PwoApLJMag5G1YwVGNaITaLF0Q23onbcH3sV/X4beZBu9L+alGSdh+xPQQAGN2FrntXX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734957830; c=relaxed/simple; bh=c//wAMnNvqiy5NJHbu+24565dcsJqgWrXqfK3VBXsAk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kmKZ3WcoMvd721flgB/6qus2sK4rX8oAgr1nidzA6E3YteIrv+Qw+BuwlyZunRXZ7XOwUsLRry9wmDsbUyb2dIzfhJ1knSqoT3sVHiCmjbpieun4iyo8JsRobmtKHBoS6yvGVtltIabcyp4yZBzPsG0Nngk9i8CjqapNwIfGI8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=cPQ+LU+0; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="cPQ+LU+0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1734957797; x=1735562597; i=markus.elfring@web.de; bh=c//wAMnNvqiy5NJHbu+24565dcsJqgWrXqfK3VBXsAk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=cPQ+LU+0vXzHkqWmGUlbEZqUN4D0+fbRNM29RQUG57TmqUZdqHz9GVJf6DAuvi73 83Y0qv5NpQwjHl/qV/eM7rwpY9g7AIFjRuKQjZkL5a7dxSr5l49yh+aFS84FLF6YK uVQBK4jK4NQD89/fQfFEWXz8MU7w3X4JP0LMHYSkOcuwwbERVrTZ9vECN/QFO2Zi4 KiLnYHKTpl7gtRaXs64Ssw1AwfL6u2W65coH3L6UUhUQ0NHrLcUB2HS78MlkifoT1 4+tsOS6ZCwmSGFj6nIBoa/590SaujCdXC7kpuwWUfsf6xiAHOybzoYPSuCdXQmiOp 9WeUFwnOq0fVUTgFbQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.70.31]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N2BMA-1tY3BL27Bu-014LPW; Mon, 23 Dec 2024 13:43:17 +0100 Message-ID: <57318436-1462-4984-a863-8c8da4e96792@web.de> Date: Mon, 23 Dec 2024 13:43:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions To: Karan Sanghavi , linux-mm@kvack.org, =?UTF-8?Q?Andr=C3=A9_Almeida?= , Andrew Morton , Christian Brauner , Gabriel Krisman Bertazi , Hugh Dickins Cc: LKML , Shuah Khan References: <20241127-unsignedcompare1601569-v2-1-e85098fb02b2@gmail.com> Content-Language: en-GB From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:h1pIxDrxe0ggHppeFhX8vP7XYd0RWkAQvZpgtJOm48tz6Ku587x ypf3Bjyc11qUAHkrazJ/GjUL9awJclnGmPHG6pHiejc50e5cqwlY6ZbBJYBgbsN/FRBsoYr KOckCFYWpa0W2j+38hTnK/hSauEcN3WroxxChoQUUvu9+IUq+fBIbZ1Nz/Kz2v/9iFuUcb/ dQkpHYxlEnztmrlaakv7A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:gv3nvFyhGlE=;Y/TK4kV+I0pxzmUwj+ibb0ddepX OF11cxSzkGOQUzQcV3+Bm8ahJ0wiwRJSqZGAt67ymF5YqAk1IWgSQdbPIwuufyQQdcncFZx5Y xCiWJ3YRTEv08Yn8+tu64bqjnCIcljzbZlwI+/SzfFtjucYibe7IAWiG/XtIF7vK9wq+DDmNp NJFlC2uAc+4kvGxVTVpSYdPeDqtOK2WFf8N63eNBiONpZ4sMfltFIyKE/eyvJe/iSYQM/CVyy GQN8cLy+wObWGyEUbL6Cq/ahIp/xYs5abTr2ywEgnncsCO9/Gi/RL3EVDelILUqzmThcg8nsL v+wY93ROJ1/Nu5DTsdhE2ulV39iZMAYjp1CbKCtUX7jG6dAk0Kh0bXg55xjIMfXc1dsHYoo6J 4t/wtjzBaYucwnkq8IDYhibfrHrgpQS0OwX4PD/I8DMC0B7dH8ys3Q06jqNUomWsyAIJb0dvV eG96PvBzCmHoYxQ+tBQVjxNCK/oVmT+zYJdhcg3TkG6Hjtliev+7kCbHMJ2lGgtdv5rlqVXtb 5U5jeXzTSlUY7/w1QhImsxlH2RZnGP6fVZQyB+bR6879VwMOJ7HYnkGzbfNJwrlrHwnNJ5Xib S9ZCmQAWrBSUG5cHLPiYrMqdAZZks8G0O5IA+6SY27Z0+YyDTg3niVgRPk5zkhQDkpPi/qFCx YFp0BLed2ivJ5A1L8p3nSqLBFStaEqUuzGf6XiDmq6tndkaPd4fOqE0A4U5yOrp/Hi9Hjjv54 hjvKTfIaV86liv5FFPfFsMOIOgmA959Nb1y+bh/Wn2beVwa4ee5Vu3a71gnKDb78Hq/B7LmBP SVPWmwzcGTZUCmUNkPPCbh+KQh1YuXEgktB8MQPY1lYnA2m91mJmA29e+IWT5ExpzptGO2OG2 yKvQO/AMbdbOhPCTkyRXFUTgGf5tpSY8w5T4QQxf6N/ZMNC7xLmJYC07oD45OaWTwmOw9Ce1u mbz8Ds3IUKbAACM5CWFm32JLP0iSBwejpj1W7gfAP3FbgVoAp3zLz1F0NH7JZG5Gwr+rgRC4a QUePKb7ttyegWy9l7amb/zcqz3pRzEZs7mL4lP1ZMesGr5OqxlEyHwwj/H7SwROIlKu806vyQ sXKa9yECs= >> Use signed data type for version handling >> in shmem_parse_opt_casefold() How do you think about to move this information into the summary phrase? =E2=80=A6 >> --- >> Coverity Message: >> CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT) >> unsigned_compare: This less-than-zero comparison of an unsigned >> value is never true. version < 0U =E2=80=A6 May such information become a part for the final change description? Regards, Markus