mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Angelo Dureghello" <adureghello@baylibre.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate_hz on adaq4381-4
Date: Mon, 11 Aug 2025 14:18:10 -0500	[thread overview]
Message-ID: <5732b907-ccb8-4302-8fd7-ded63a5d852b@baylibre.com> (raw)
In-Reply-To: <CAHp75Vc_-2czsaZ_-3+cSWAzyvz-PASR5mjCyoAxTu9qSEYyLA@mail.gmail.com>

On 8/11/25 2:07 PM, Andy Shevchenko wrote:
> On Mon, Aug 11, 2025 at 8:32 PM David Lechner <dlechner@baylibre.com> wrote:
>>
>> Add max_conversion_rate_hz to the chip info for "adaq4381-4". Without
>> this, the driver fails to probe because it tries to set the initial
>> sample rate to 0 Hz, which is not valid.
> 
> ...
> 
>> +       .max_conversion_rate_hz = 4 * MEGA,
> 
> MEGA --> HZ_PER_MHZ

If we do this, we should fix up all of the other similar ones
in a separate patch. So I would leave this patch as-is.

> 
> With that done
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 
> 


  reply	other threads:[~2025-08-11 19:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 18:32 David Lechner
2025-08-11 19:07 ` Andy Shevchenko
2025-08-11 19:18   ` David Lechner [this message]
2025-08-11 19:22     ` Andy Shevchenko
2025-08-16 13:33       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5732b907-ccb8-4302-8fd7-ded63a5d852b@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=adureghello@baylibre.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®