From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbcEMIHa (ORCPT ); Fri, 13 May 2016 04:07:30 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:35656 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbcEMIHX (ORCPT ); Fri, 13 May 2016 04:07:23 -0400 Subject: Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile To: Maxime Ripard References: <1463047851-2039-1-git-send-email-oliver@schinagl.nl> <20160513074823.GA3733@lukather> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , arm@kernel.org, dev@linux-sunxi.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai From: Olliver Schinagl Message-ID: <57358B2B.1010703@schinagl.nl> Date: Fri, 13 May 2016 10:07:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160513074823.GA3733@lukather> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org and now i'm embarrassed and ashamed. Teaches me not to rush things, right? i'll correct it and take some time to do it right. sorry maxime! On 13-05-16 09:48, Maxime Ripard wrote: > Hi Olliver, > > On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote: >> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new >> emmc equipped) lime2 but forgot its Makefile. > This is still not the right commit format, the commit title should be > around double quotes. checkpatch both reports an error for this and > tells you what the proper format is, so please remember to use it > before you're sending a patch. > > Thanks! > Maxime >