From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932723AbcFNSfp (ORCPT ); Tue, 14 Jun 2016 14:35:45 -0400 Received: from mail-bn1bon0062.outbound.protection.outlook.com ([157.56.111.62]:29472 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932336AbcFNSfn (ORCPT ); Tue, 14 Jun 2016 14:35:43 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC To: Paolo Bonzini , , References: <1465922420-53802-1-git-send-email-pbonzini@redhat.com> CC: From: Suravee Suthikulanit Message-ID: <573935ff-2310-b64f-d3c9-260a89de6752@amd.com> Date: Tue, 14 Jun 2016 13:20:30 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465922420-53802-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR08CA0032.namprd08.prod.outlook.com (10.141.200.12) To SN1PR12MB0446.namprd12.prod.outlook.com (10.162.105.14) X-MS-Office365-Filtering-Correlation-Id: 66e29b76-64ad-4b22-b406-08d39480942a X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;2:/c+kq9kNOV5tSrnYiybQsrx9UC0LF/UCPTw9IbuO6+zZ8rVkPbShyqAAaOtHr/AcXyux2RjKqQ0qELVE5BzkM7eoa3GDI3IJv0oezJW5oDSAIvikKBd8nJ1Oodszc7uS1pv4OLLbya4r3q9SrsVXuVQ+sjQ44sujtPc4nlfmxT7xlEttEB2wzx5y/Nt7P1pw;3:uaz4ACOorE3j+e3WrN03hvAhQWUjT4y3pndRCy10MJDA7+tfU4/mfmrX8hxjAFIz7Sz+2esescQzy4w08gxl4lW6x41LvYXhlJxFluLwLuEGS385l0HI2I1LNWuLuXvz X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0446; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;25:Ssu0LhlEC28Afd5ELCZc3dMWxff7PfufjjZVUi9UyQU1fRwdbnj6zcS4rqVEGvZV+P2nQFPaYc2l1E5P0D9dsJuR6oo14jmrjb709oGu2SQxRJ+K4jKD49oLvJkW3QVHeyW12O5N+6qvFVTiYQw7o6RK7haN3YRkNPo/5HFJNBJSBIcl+r9cgZSZVmxS7E5ByZv72LuX1nEBjs6uT7vtd1d21yFl/TC4MN24hkQlmglmfDHTGM7IMZlL9REioppTbkVHGjFWJ+VaxbpVfVlVNR36lpIDc+hDFhuF+SIa7lN5MQe7yTRwWWzvnZtSZJQOQ33yW47GtdRPWdRmUHJQLhcgoKnvheD2QOhvrO62BNPzqoQNpsXqMJJOV/2gtOefGUjBB9M/Qz3ohFzfBgrvk/9XGHoZBgplIJkh+9V1JU8oh9BGrcAIWq3hScRVc+8pn2c+PKRFbZNvbUVvJg4ae5bb7dNmT+CWMzjJTKAw0KXJblRG+ota+W+FW1CoRnLHOLec8dFzYF1k66M0o7C1IbHjvDRnZsbBv5pIRXPkVq95X0aMVmSMcRLPcj4l6DodsLWdOkPA5SQRnkGIDmUWhH7H7nN/Ydb7zVyOMUv+dfNajZvUiu4i/stE9LsTAo3uo8UiG5Zb+Kt/DepNJEANW+fzKRxvs2grs5+d5QooshBf+Ad8kVniKK/gaC1r2aOQjRkZ+tsJGYgLaUPbuPleVw== X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;20:3kGKOLlZs/Oua3vrow/q2HqI7br4RP3TadbC+hxLRuRqiXx1buO5cbHArWhQ9mhAx+ZysNa+lZaLlux2HnTK3PbclFYT+FUWxmvntda+HffLSFwGPyp5WnRzbwW1zBiCtwc2OoyOpmUVyly+8awMvrBMfsmFPIr57YUSEs8xj1ogWvar5f4nWIAGHPCWbDIHxs3OlE4C+SamuKu2SSB3geFQSD2jHpNiI2fUipvHyV5+irjxCJjf5fW6aWuE6pxfDfXFznUBBY0n6jF/c64CmAN8RjuQVqmsF6e9ado2K8pWfKR0bXzzqQLoMjxTFH0bHwXKXwrmmcFvYcsx8YDDvivDYYbb4nHKwe/7bZ6m2CHIGONk3bl3e8ujZM25JQp8buwo7TLOqkd60PB+auHZliiVYjmBMaKJFdkhTItYhhq1fG8xD397QpkYgXOrxJek37v6pKAOOW+dizELrhvTuGNMCKiTBOjjv0EAYwinuoOA/Kp/Cn7CVglsk/Fv7503;4:zTVt4cmxO5i5YKXold7K6ODo9BR6KvqdRz3srWUNEIwN9hqoMdi2ewDYP2nn0IALDXIMrtxrZhAWRTjh4rGqdwxm1PrgxDP0J81XGfeCs4HyRneA0O6q90oC/LVfqijWyIJ7ce5726Jr+L6M4YrYzEp5FSgvW+cRbO7h0xnOkXCl7SwPQzFnUuH50UErdB9Q08VqcMtelpSSVb+k0SSEe3URkzdgYMsjx/NDg5fDQyTKkoYnfzaA/UIcdCqjxXygGnhfiZ4iH2xrwdiLTHrK2inEptrEifkG7tsY357ZXwloQpspAmS/SHv1QLExdRDeQ6YZlgRAAcwTWG4PhG2HcF9FMxp5kjXJ4YBwUXgV3l9ZTi9BCQF+/RPap0gSbYUdboy2lHRj6Ex6h5eR4LaeSQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:SN1PR12MB0446;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0446; X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(76104003)(377454003)(199003)(24454002)(68736007)(5001770100001)(54356999)(23746002)(5008740100001)(2201001)(586003)(8676002)(3846002)(6116002)(81166006)(81156014)(97736004)(105586002)(50986999)(101416001)(106356001)(76176999)(5004730100002)(83506001)(47776003)(2950100001)(50466002)(66066001)(31686004)(65956001)(4001350100001)(42186005)(36756003)(4326007)(2906002)(189998001)(77096005)(65806001)(86362001)(64126003)(33646002)(230700001)(31696002)(92566002)(65826006)(15760500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0446;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0446;23:xUORBIHI8gbLLSpR2OiwHxmQxFK2ehX58OLFj?= =?Windows-1252?Q?xUBE3l/ODQ/aSUDx1Bs7ud7+KQrgmIsI6Mm2+Bk4k0a7HpklLXUPgG/w?= =?Windows-1252?Q?ujPdpWNl3VG6Ttl2qCIy8YWpdwAc0apXbD9kKvZMSQrnpsKGqbU8oJed?= =?Windows-1252?Q?llB0oLLiZyXto1PH918WJcw3Rj/zXP7b/E+J7Ene2ZRVOjYdohnMlJCI?= =?Windows-1252?Q?G4TwxeBNQOyYbQY2sY7za1+FsoiKkoUiQ9u9hMwreSVqCSfkAj2eD4AT?= =?Windows-1252?Q?aR57lpomjSK97V4xE0SqeOeYWcZMzmu19bGaneLk5rWSGatoADt9+w+W?= =?Windows-1252?Q?GBvFHJtxnc6LkEk3HpFOs3pp8mfqw51/6+GsG9mOXoqu0yNNAQm+hyzm?= =?Windows-1252?Q?vcWzH3dj+ATbZIdRlBtmP3WMkSnJAthgFsYjFG4Gvi0SsmYBg0i5xmAa?= =?Windows-1252?Q?Cset/RZ4HXGCGn3A9b6PYRlI00pRYQXanZmPsHkWKHyF/gbp4UZASzsX?= =?Windows-1252?Q?8VULFS9Ec7YJirzPYzp2APY1RF0U6OQNiZUffR+SboPWv31lsrAWdUYT?= =?Windows-1252?Q?jm9Utvb+f9XYfUN/V55Lq5Hwspu7CTxffLEyod0vQBPIKviUEv4yIihY?= =?Windows-1252?Q?Lxx5u7oUCclxI/5bVrCdEtR95q5bVUkJXsYUBbUBGG+9RjjA0EhC7Cep?= =?Windows-1252?Q?tMWtrezqE5kvQOQwb3aa2iD9yPk5gmIDLW2N+4eEEOvV5kgllqQoMkhl?= =?Windows-1252?Q?9CX2NkMjAuKMIhNUg7zQsFS+YOjvDtQkiynqysO7x60DVkf4uzh/6ZO+?= =?Windows-1252?Q?GBsBNaQRIe/G6sI4tdfD/QV+pu8mSf0eVEAxrQiAsuR+8AqE4Gq3pHg4?= =?Windows-1252?Q?UoTOjuUzXLDIy77JNvz5DMj6f+EbwivMdOOoFTVKD7+Vo4vrfNuV6yaz?= =?Windows-1252?Q?PTPDGbkXPS83f24kL9NtW386Zz9ZKfmL9IZhsKWQWhWrXVX6kOsvhPAd?= =?Windows-1252?Q?R/89yIIRA89ZC4DRPtGmDI2j+N1llOPVZ1YrcgZZ7genv3sO8kjAVNmZ?= =?Windows-1252?Q?bTuL2H41PasHSRvabwC+ITa2MAzPH6OBdvcHgTkWTDsfTIG6Zy0Q5SPp?= =?Windows-1252?Q?I7YBlV+2ON/R2WSbtuBldeIMKRJvNNx2B6w2VQggPdK6cChQ1oZXG+vF?= =?Windows-1252?Q?Mc6iatGPMytxgsbN47gtJnVv9zOnFL0YusZAsOlPrWJX1vNtQSuGFWuQ?= =?Windows-1252?Q?CUj4ldm1ZY1EcSbVr27+BjEzTg0vtJVReDl7UbRk5WRD2Li0qhnXv1HV?= =?Windows-1252?Q?o/VjQ9M/H4ARwIpZFCnIU39onF4dLSTOiQLQppaG2ObTKniB0ZL2zIgP?= =?Windows-1252?Q?5cNJS1ZFSah55Ag2uMQYmAM6QE9WQrs+w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;6:VqbTnIxvExhUxl+gRt7KqZP2ql/SmqR9acfSMSowmL37AuKMU8ufE+rHovH5Ewr65jpdW17glyANTBEfglVgwgocWi5ctowhcsvo8z6LyM3/iRlhwLt12BNFKj85TwgWvJkTUJIdDcRP2a78echMIs7pgMkbgX7S3NvzukxUEWS5OaRsn+kKYHis0o0tJV4hZy8Q6fPenUALr98hI7xnAMS7vtFIusK9WFBn+kyVPW6qvUFNBE+v3qIrOW72Q3H38NVMz7wkwdu0v1t0z/7OH/jK6rGCZ1r9zirHk80+GqJLrpDMjSvyf5PbMbTxfCkY;5:U4+CsIMNfBmbYj0+oGNfDt/20RBHojehX1Bz9PZbRf0TOHQqDAMjH2jIHGSwSTF6N85jnG6cicGaWZo4/aK2OStC6nEY3u+EYFZL8sL1EkOldPRc411A03PENXUlARfi7O1LuXtu0o9v1wcjbTCgEQ==;24:AWFjeRTgQx4ukoCgjpkoaxBIQ9foBx4IbFYS8NK4uT7Big6esETQLFaJ7zozpR/1bIybIXPeWBspwXaRhqOlsYkuYV38W0A33MndPd+tw9Y=;7:P1ZG8jmZLxNPj5Cm4yOxoPqMIfN5B8WtJjoqv66rsV1+MVfsSFz7sM/GVGfJXq1q0cq2RmvggjHm0sndsa+M1dNctjSOalq+SrJginX4UBZHAyDd/I42mDiKqo2Mjy7WRCA+DtxpATp/du8jqd0BA23ynywUkSTMlrGfZpTLeo84h3wBDYn5ZGJkXr4fFlH15WqzPFqZZyAcQaujENPWHg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0446;20:69sa0XEnR/hlyrXcWhrCCHsZyWGIDILkjSxZVkrkeMP0Lb/S9AoldBfHMw01vrmRnY2U5Vn1VglqvH86F/YN3ftSg2RvvfIkdkvYfpBTwxagKacVqHxfdBmGpS/7ZIILsWVj8vdn7/tSFU8RhHhHO52UxMW89KTjNxHXOM2X2Y6k1YQJImrDOeBgKMWsFJKjmLAZ5sCKv0tI4S4oaB81IzqvKiW972RGGT4B6bq0SPt9wwuTfpLuGiAeMKPfVBXf X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 18:20:34.6688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0446 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paolo, On 6/14/2016 11:40 AM, Paolo Bonzini wrote: > AVIC needs __default_cpu_present_to_apicid. Stub out all functions > that use it, and disable the module parameter, if Linux is > compiled without local APIC support. I think you are right that we should disable AVIC #ifndef CONFIG_X86_LOCAL_APIC. However, do you think we should just use default_cpu_present_to_apicid() instead of the __default_cpu_present_to_apicid()? This way, we can avoid having #ifdef CONFIG_X86_LOCAL_APIC in multiple places. As for disabling AVIC, I think we can also do: if (!IS_ENABLED(CONFIG_X86_LOCAL_APIC)) avic = false; What do you think? Thanks, Suravee