From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbcERJGk (ORCPT ); Wed, 18 May 2016 05:06:40 -0400 Received: from smtp89.ord1c.emailsrvr.com ([108.166.43.89]:37896 "EHLO smtp89.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbcERJGi (ORCPT ); Wed, 18 May 2016 05:06:38 -0400 X-Greylist: delayed 527 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 May 2016 05:06:37 EDT X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue To: Amit Ghadge References: <1463504024-4448-1-git-send-email-amitg.b14@gmail.com> Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <573C2E8B.1040009@mev.co.uk> Date: Wed, 18 May 2016 09:57:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463504024-4448-1-git-send-email-amitg.b14@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/16 17:53, Amit Ghadge wrote: > This is a patch to the quatech_daqp_cs.c file that fixes by using > unsigned int instead of unsigned, following warning found by checkpatch. > * WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Amit Ghadge > --- > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > index e9e4313..802f51e 100644 > --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c > +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev, > outb(0, dev->iobase + DAQP_AUX_REG); > > for (i = 0; i > insn->n; i++) { > - unsigned val = data[i]; > + unsigned int val = data[i]; > int ret; > > /* D/A transfer rate is about 8ms */ > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-