From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbcESLSb (ORCPT ); Thu, 19 May 2016 07:18:31 -0400 Received: from mail-bl2on0060.outbound.protection.outlook.com ([65.55.169.60]:18803 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754033AbcESLSa (ORCPT ); Thu, 19 May 2016 07:18:30 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH] amdgpu/uvd: use kmemdup To: Muhammad Falak R Wani , David Airlie References: <1463656317-13828-1-git-send-email-falakreyaz@gmail.com> CC: Alex Deucher , Chunming Zhou , Jammy Zhou , Leo Liu , Sonny Jiang , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <573DA0F2.2020503@amd.com> Date: Thu, 19 May 2016 13:18:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463656317-13828-1-git-send-email-falakreyaz@gmail.com> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2a02:908:1250:ae81:e06e:5e9b:4940:a9d7] X-ClientProxiedBy: DB5PR06CA0033.eurprd06.prod.outlook.com (10.162.165.43) To SN1PR12MB0143.namprd12.prod.outlook.com (10.162.3.142) X-MS-Office365-Filtering-Correlation-Id: 8b43159d-8903-405d-b29b-08d37fd74cc2 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0143;2:WGB0htA+n2tYk8h35eHpylgHUXGvtfj8wPGlULhlzsp9r8j5E6mT1y6cY6AMzogHK5b1vJeDMTe0/IKl2wSYBYU+C3jLZauI9+jUE2cJYocTE499ZMNU6765c5c4lVdUOF7stlJK+6YWR9k5FjjGmjbPH6tpr3qr3gKmk1Co3ERnkxcBA1Ode14LQhlSpxfD;3:+cxxG7kQzzfLxC4LP6kjuhIiUpf11BsCNpOjh75tqoJsb+rIhmjQVqAGHSlkFjo40KpcNGTbRMiQO7lsVaXttPYWAJrffh3lpnlDUJtlKAmWMS3w8K5N9XcjmYOpYdSk;25:w3Ew8xU7T3vnZbmuopA2qECT4RdrIwVeAxaH6GmPcQV3ciuQcX0wLPZ2IQoXnUfh4EZsLTg7q0XiPhaGBSZzT+bJ5R2qvN+ZpT6shQn5ojfLj2DBZfhp1yQV73n1t4CI0okeBhXywgixatvNrF8jX1+LyAkxOvufVCzlhs63atwOqQ0RKo+RxKRWBzLpQB1a9kChmz3m5nvz83EJ4N+iXPCu6Uo2VvwmJa5kKqJNWayZyCvUr4ocBhTZ6tvFxiwUGkgxASFVRVM62EOtrlxc61g1OHgEmO/b7HdavtgCJagwkvWXNcG+VRp7BzeiFZBtlGqPTpfb/Ua+jQTBfcFg0QUzQvJN2LikqD4ZcmQJCvpxBKRPj1P89e6dFYEcL4Twq2ck2SPIdmO3dShOZsVu5QGoz1+Vj9jtiqmvgjbzSRk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0143; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0143;20:x8gSYm4V9DHaWK4dZLU2WTJtcOq5uUJsKhawxd4rYEmqZci7RubQj6R0doxCMvdBe66evf7DrW3ItUfBEPyKbTg1Gkeq7MzQ2HndSYyrglym1I3WB+MUTRk1byq970hkea6X9yVgZcMEgAvcxCGBlP+UUPvFBYBEvi421nUQvsTnRdOHRDUNW8mwBGuXuI3XStYXELk8YoWMvqD80Sb5kD/+8WFt1Wyn6aVBMhoUvjrKXdPbta975b58yENwGboUT5GCpvPC2alopNE9SbhA84pSgL2DzQy4VAUu5kw+Dr88HrTqpDFdwtUtpbOwBxYAZcT7kSiBa4qWCPLFA+0kqsV/t6pDodKQcWxTfrUCdVKojzAp6pqNY95y1uxjuxNnjYzQHQXMzGJOqUP02L8DgTq0NLHZFfipgu3yJpXH4c6KQIKu6gi6MWbWPU5p98zaM1/exYkNXb1tm/ssJXnBM15x4VO8CFHqK0spnMJovbJ5C6boNM66TALMwlNEM0tC;4:y8jYeXkyvYu+AxJaySuHTzaGxvreb174i/+cjRws48lNQC7fppf9M4l+Y6NdFUA5ooomIFh9BroWJx1ckpDUq9qG+J9kG0ZOEcLZ8q+PyKuIFjUWwtYrjRXFTE9naYGkfHR0loRd2JAcrth6mSyU4Xz++K6b1AGYsTuvFPgAx6ZHdc7OVmXQH9G4DfxOXECXh5sy4FgPxJm1Uz7zk+XCEqfCjx3OSRQHma9EHtsqTTjKO53yC1cdpCBl9uihnY8NcM7Q9XP5BVb0YanDkZKJG0KTB6k5CF4WPnD/3CVDRr3zZp6Ot3HRUlrAJLtAI3ovI5UPzlVHKtAG8lOsxWiAea479769HrLd+ctTHqq085uM6Vdw6iYNPfM4oKuYRuwV6UuswiZj0RU0fmrjBAITKQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:SN1PR12MB0143;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0143; X-Forefront-PRVS: 094700CA91 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(5004730100002)(2906002)(6116002)(4326007)(42186005)(586003)(5001770100001)(65956001)(50466002)(36756003)(8676002)(81166006)(189998001)(86362001)(87266999)(5008740100001)(19580405001)(80316001)(92566002)(65816999)(54356999)(76176999)(230700001)(23756003)(64126003)(50986999)(77096005)(19580395003)(2950100001)(33656002)(83506001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0143;H:[IPv6:2a02:908:1250:ae81:e06e:5e9b:4940:a9d7];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0143;23:hVqE315CM9QUfkrWxP3bPs5exOKxJ1R7/bZtxJDbp0sxPUZQoW15gTP2nZ/girpdeiOA0/A11S7PesV/V316/j6MUu/MM9x0ZCDqJ6apEqiEq1XV2gAd0kSgdoXRPbrYvnnAmk5Un8JeO8pJUTPGBe4NIRJw//+cesc3xcvUZSF4FIPj36gX4sHUqk1yFRZUTEasrkwjeylQ8z3J9E6siv9v2YhVw+t/kZPRhlfVZDdTMKQ4thh8ZlMkMrahYIOqif48QoQ9sgNe/rGSCbRokOAug68ASaUY5lMysIjfXIJUEeHS7AD1jQ0oypatg7pb7yrImGBw/2kXNBTA4Tq11cEzEfeQkLV9JUmZm7UprFXxi8RcS0AZpj7XfBSrRTV4fzpDjf9oGpdU8FbmDBLMIer1S2J5Ju5kxulBKuWSKk5RDR6TPg2HGDpwLVeMetxtF8a5vr4t2BaHGLnvPVKJIonbsi66G4R6/zg8aP0BWx3BHyb2vVcJJLywIBgjuFHz5AzzgZJPlghbDt1Xnkg3xK/z0kCLPPmjd8gc1O0CbTLoSL24QLnOPG26MSrHrbRZ+pfUrjbRPtp0Yhz66ZExs8ogC8gzLaP1Cn5dihig+C7tXiLJy7dx0GrWdqRBc9yWolT8CAD08JqRNjngyoa3WhIfRXEUmHbtD4EYIr2J84uJ6kLbDFnVCXbYnuM17qPN7ufsO2i9hSjRXiQ3RoBmHWpRHOb/xhDxhEFpBCv+pL2IiQZYfH9991gWPUarTEXJkxwELqAaot2w6dghlbQPNEZey+PuJRypsncXI3KQzHsEFn0pf0VE4gdbA4Qn8TAkhxQkRNebHMNeJ6vtRqull3OFYswVjgnsbYjFPBA/II1ZN7Ma49Me4ogDNfdLAdlC7hNLbRf4/I5kkDD11Yv5czgEEE7DaXC0KPihD4P2HyA= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0143;5:wkcLgM5TPsJMrhuZtDOQzmQ73Aok6W2jACns7KDCorAuuSGKNwBOQtxaQ8VS/f8yQu69wryEN0RS5z0+zw/mkaaodWBTJgb6IDYR6qQ/47M5e+Z6P1ptwAPXGURCfWm4hcqwwSQ/828Qq2oswPrsMQ==;24:sgPe7Nydzhf358alsyMW/oG90goTAjzxJgHJ7ZiKVtyi3Qa1CJiazfj2OUcJjJ8XT0O6qDxOJzdayQvBuBRlI7H0dys1B6AsiIl5RdyWURk=;7:VDY1k9FCU91U4iitWU/vxHWbu0GGgDkjuz8nAtfmggpQVAau4NJ4qWw6Jd9QyPCB9LAAVaIFEIhJdOLMRb3wD0sTjhtfVDo3bwW0y5YofWvAiNATw4RAlhTUVTAg/93Cio1W+yrVGqMYOH2oiCOBXCfMrXRdHy4x0sxqjwXLSrI=;20:GtvmQMpIgpe10irNiPXweu6vziweyiYLsBFUvM1XGV2cK4ryRGkbgPh6czDMajeQkihCEpPjh9nmsey4WQfbb4JUcLimUn8FFu7ZneQVzek6/pWhAwHfN7r4rxIrFhGCtvvDA/TWEVhIgNBrJsz8Ftbk1NDEgG8UklFtdoeLmiM5X+Xfk8Um41E7dpBBqqW11xJHpS9tdo+d+HAdTbBL/aMVrEzgbnZaWkwR9ux64eFVnmz2JGEDPWj+MRq1SGJ+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2016 11:18:24.4864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0143 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.05.2016 um 13:11 schrieb Muhammad Falak R Wani: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. > > Signed-off-by: Muhammad Falak R Wani NAK, actually using memcpy() is wrong in the first place. The UVD BO is in VRAM so the pointer is pointing to IO memory here, so this should be memcpy_fromio() instead of memcpy(). Christian. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > index 01abfc2..c977ab6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > @@ -295,12 +295,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev) > size = amdgpu_bo_size(adev->uvd.vcpu_bo); > ptr = adev->uvd.cpu_addr; > > - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL); > + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL); > if (!adev->uvd.saved_bo) > return -ENOMEM; > > - memcpy(adev->uvd.saved_bo, ptr, size); > - > return 0; > } >