From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932613AbcESQKV (ORCPT ); Thu, 19 May 2016 12:10:21 -0400 Received: from regular2.263xmail.com ([211.157.152.5]:55475 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbcESQKT (ORCPT ); Thu, 19 May 2016 12:10:19 -0400 X-Greylist: delayed 341 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 May 2016 12:10:18 EDT X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 220.200.28.94 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <90efc5cdee881d34632064a3a42747bf> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document To: Heiko Stuebner References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> Cc: Mark Brown , linux-rockchip@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Xu Jianqun , Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Caesar Wang Message-ID: <573DE3F7.6070300@rock-chips.com> Date: Fri, 20 May 2016 00:04:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <3685935.dKdIbE8hXb@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016年05月19日 23:51, Heiko Stuebner 写道: > Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: >> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 >> family SoCs in linux kernel. >> >> Let's add the other SoCs, in order to a better understanding from the >> rockchip spi document. >> >> Signed-off-by: Caesar Wang >> Cc: Rob Herring >> Cc: Mark Brown >> Cc: Heiko Stuebner >> Cc: linux-rockchip@lists.infradead.org >> --- >> >> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index >> 1b14d69..305b542 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt >> @@ -6,9 +6,12 @@ and display controllers using the SPI communication >> interface. Required Properties: >> >> - compatible: should be one of the following. >> + "rockchip,rk3036-spi" for rk3036. > shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver > part (patch2) the rk3036 still is the same IP as for every other soc in > here. Yep, the same IP. Do you think we should keep the below style? 1) "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. "rockchip,rk3066-spi" for rk3066. "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. ... or 2) "rockchip,rk3066-spi" for rk3066. "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188 .. or 3) "rockchip, rockchip-spi" for rk3036 rk3066....... Think about the 1) will be googd select. -Caesar >> "rockchip,rk3066-spi" for rk3066. >> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. >> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. >> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. >> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. >> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. >> - reg: physical base address of the controller and length of memory >> mapped region. > > >