mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH v1 0/3] serial: Do not count XON/XOFF in the statistics
Date: Thu, 4 Apr 2024 07:16:55 +0200	[thread overview]
Message-ID: <573aac92-9c9b-427b-a76f-3c0b7c3b6ce6@kernel.org> (raw)
In-Reply-To: <Zg3VHs-LVxHFdi8V@surfacebook.localdomain>

On 04. 04. 24, 0:15, Andy Shevchenko wrote:
> Wed, Apr 03, 2024 at 05:46:14PM +0300, Andy Shevchenko kirjoitti:
>> Some drivers count XON/XOFF in the Tx statistics, some do not.
>> I actually a bit uncertain, but I _think_ the correct way is not
>> to count them, hence this series.
> 
> Okay, it seems there are much more drivers doing that. Perhaps we need
> to add that to the rest in this case (i.o.w. invert the series from removal
> to addition)?

Interesting, perhaps cut & paste?

XON and XOFF are overhead IMO. So should not be counted. When they are, 
they mangle statistics as in transmitted (real) bytes per second.

How are they handled on the RX side?

thanks,
-- 
js
suse labs


  reply	other threads:[~2024-04-04  5:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 14:46 Andy Shevchenko
2024-04-03 14:46 ` [PATCH v1 1/3] serial: core: Don't " Andy Shevchenko
2024-04-03 14:46 ` [PATCH v1 2/3] serial: fsl_lpuart: " Andy Shevchenko
2024-04-03 14:46 ` [PATCH v1 3/3] serial: sprd: " Andy Shevchenko
2024-04-03 22:15 ` [PATCH v1 0/3] serial: Do not " Andy Shevchenko
2024-04-04  5:16   ` Jiri Slaby [this message]
2024-04-04 15:54     ` Andy Shevchenko
2024-04-09 13:46       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573aac92-9c9b-427b-a76f-3c0b7c3b6ce6@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®