From: Sudeep Holla <sudeep.holla@arm.com>
To: Jolly Shah <jolly.shah@xilinx.com>
Cc: ard.biesheuvel@linaro.org, mingo@kernel.org,
gregkh@linuxfoundation.org, matt@codeblueprint.co.uk,
hkallweit1@gmail.com, keescook@chromium.org,
dmitry.torokhov@gmail.com, michal.simek@xilinx.com,
robh+dt@kernel.org, mark.rutland@arm.com,
Sudeep Holla <sudeep.holla@arm.com>,
rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Jolly Shah <jollys@xilinx.com>
Subject: Re: [PATCH v5 3/4] drivers: firmware: xilinx: Add sysfs interface
Date: Thu, 1 Mar 2018 14:44:11 +0000 [thread overview]
Message-ID: <573acd04-85c4-829d-a0d6-36b3958ac1ec@arm.com> (raw)
In-Reply-To: <1519154467-2896-4-git-send-email-jollys@xilinx.com>
On 20/02/18 19:21, Jolly Shah wrote:
> Add Firmware-ggs sysfs interface which provides read/write
> interface to global storage registers.
>
> Signed-off-by: Jolly Shah <jollys@xilinx.com>
> Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> ---
> .../ABI/stable/sysfs-driver-zynqmp-firmware | 50 ++++
> drivers/firmware/xilinx/zynqmp/Makefile | 2 +-
> drivers/firmware/xilinx/zynqmp/firmware-ggs.c | 297 +++++++++++++++++++++
> drivers/firmware/xilinx/zynqmp/firmware.c | 13 +
> include/linux/firmware/xilinx/zynqmp/firmware.h | 2 +
> 5 files changed, 363 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/ABI/stable/sysfs-driver-zynqmp-firmware
> create mode 100644 drivers/firmware/xilinx/zynqmp/firmware-ggs.c
>
> diff --git a/Documentation/ABI/stable/sysfs-driver-zynqmp-firmware b/Documentation/ABI/stable/sysfs-driver-zynqmp-firmware
> new file mode 100644
> index 0000000..b04727a
> --- /dev/null
> +++ b/Documentation/ABI/stable/sysfs-driver-zynqmp-firmware
> @@ -0,0 +1,50 @@
> +What: /sys/devices/platform/zynqmp-firmware/ggs> +Date: January 2018
> +KernelVersion: 4.15.0
> +Contact: "Jolly Shah" <jollys@xilinx.com>
> +Description:
> + Read/Write PMU global general storage register value,
> + GLOBAL_GEN_STORAGE{0:3}.
> + Global general storage register that can be used
> + by system to pass information between masters.
> +
What kind of information ? Is there any semantics for that ?
Why does EEMI lack APIs for that if it's critical, giving access to
such information to userspace may not be good idea.
> + The register is reset during system or power-on
> + resets. Three registers are used by the FSBL and
> + other Xilinx software products: GLOBAL_GEN_STORAGE{4:6}.
> +
FSBL ?
For what is it used ?
> + Usage:
> + # cat /sys/.../zynqmp-firmware/ggs0
> + # echo <mask> <value> > /sys/.../zynqmp-firmware/ggs0
> +
> + Example:
> + # cat /sys/.../zynqmp-firmware/ggs0
> + # echo 0xFFFFFFFF 0x1234ABCD > /sys/.../zynqmp-firmware/ggs0
> +
> +Users: Xilinx
> +
> +What: /sys/devices/platform/zynqmp-firmware/pggs*
> +Date: January 2018
> +KernelVersion: 4.15.0
> +Contact: "Jolly Shah" <jollys@xilinx.com>
> +Description:
> + Read/Write PMU persistent global general storage register
> + value, PERS_GLOB_GEN_STORAGE{0:3}.
> + Persistent global general storage register that
> + can be used by system to pass information between
> + masters.
> +
Ditto
> + This register is only reset by the power-on reset
> + and maintains its value through a system reset.
> + Four registers are used by the FSBL and other Xilinx
> + software products: PERS_GLOB_GEN_STORAGE{4:7}.
> + Register is reset only by a POR reset.
> +
Ditto
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-03-01 14:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 19:21 [PATCH v5 0/4] drivers: firmware: xilinx: Add firmware driver support Jolly Shah
2018-02-20 19:21 ` [PATCH v5 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware Jolly Shah
2018-03-01 14:15 ` Sudeep Holla
2018-03-07 22:25 ` Jolly Shah
2018-03-08 11:48 ` Sudeep Holla
2018-03-12 23:07 ` Jolly Shah
2018-03-13 10:16 ` Sudeep Holla
2018-03-13 18:56 ` Jolly Shah
2018-03-01 21:18 ` Rob Herring
2018-02-20 19:21 ` [PATCH v5 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver Jolly Shah
2018-03-01 14:27 ` Sudeep Holla
2018-03-07 0:44 ` Jolly Shah
2018-03-08 12:18 ` Sudeep Holla
2018-03-12 23:05 ` Jolly Shah
2018-03-13 10:24 ` Sudeep Holla
2018-03-15 17:53 ` Jolly Shah
2018-03-15 17:57 ` Sudeep Holla
2018-03-14 13:22 ` Greg KH
2018-02-20 19:21 ` [PATCH v5 3/4] drivers: firmware: xilinx: Add sysfs interface Jolly Shah
2018-03-01 13:32 ` Michal Simek
2018-03-01 14:09 ` Andy Shevchenko
2018-03-01 14:44 ` Sudeep Holla [this message]
2018-03-07 22:03 ` Jolly Shah
2018-02-20 19:21 ` [PATCH v5 4/4] drivers: firmware: xilinx: Add debugfs interface Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573acd04-85c4-829d-a0d6-36b3958ac1ec@arm.com \
--to=sudeep.holla@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=jolly.shah@xilinx.com \
--cc=jollys@xilinx.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®