From: "NickCheng" <nick.cheng@areca.com.tw>
To: <linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <jejb@kernel.org>,
"???" <ching2048@areca.com.tw>
Subject: [PATCH 5/5] arcmsr: Modify ARC-1214 Inband Messages Behavior
Date: Fri, 8 Feb 2013 14:03:13 +0800 [thread overview]
Message-ID: <5741810F8C904659B2563B4E3058B701@arecaaebe11fae> (raw)
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
From: Nick Cheng <nick.cheng@areca.com.tw>
Modify ARC-1214 inband messages behavior to make up for HW seldom malfunction.
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
---
[-- Attachment #2: checkpatch5 --]
[-- Type: application/octet-stream, Size: 10802 bytes --]
WARNING: line over 80 characters
#26: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:86:
+ if ((ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex) >= 1032) {
WARNING: line over 80 characters
#31: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:91:
+ if (((ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex) + acb->rqbuf_lastindex) > 1032) {
WARNING: line over 80 characters
#32: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:92:
+ memcpy(ptmpQbuffer, pQbuffer, ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex);
WARNING: line over 80 characters
#33: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:93:
+ ptmpQbuffer += ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex;
WARNING: line over 80 characters
#34: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:94:
+ memcpy(ptmpQbuffer, acb->rqbuffer, 1032 - (ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex));
WARNING: line over 80 characters
#35: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:95:
+ acb->rqbuf_firstindex = 1032 - (ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex);
WARNING: line over 80 characters
#38: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:98:
+ memcpy(ptmpQbuffer, pQbuffer, ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex);
WARNING: line over 80 characters
#39: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:99:
+ ptmpQbuffer += ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex;
WARNING: line over 80 characters
#40: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:100:
+ memcpy(ptmpQbuffer, acb->rqbuffer, acb->rqbuf_lastindex);
WARNING: line over 80 characters
#41: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:101:
+ allxfer_len = ARCMSR_MAX_QBUFFER - acb->rqbuf_firstindex + acb->rqbuf_lastindex;
WARNING: line over 80 characters
#42: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:102:
+ acb->rqbuf_firstindex = acb->rqbuf_lastindex;
WARNING: line over 80 characters
#46: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:106:
+ if ((acb->rqbuf_lastindex - acb->rqbuf_firstindex) > 1032) {
WARNING: line over 80 characters
#51: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:111:
+ memcpy(ptmpQbuffer, pQbuffer, acb->rqbuf_lastindex - acb->rqbuf_firstindex);
WARNING: line over 80 characters
#52: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:112:
+ allxfer_len = acb->rqbuf_lastindex - acb->rqbuf_firstindex;
WARNING: line over 80 characters
#90: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:137:
+ memcpy(pQbuffer, temp, ARCMSR_MAX_QBUFFER - rqbuf_lastindex);
WARNING: line over 80 characters
#92: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:139:
+ rqbuf_lastindex = (rqbuf_lastindex + data_len) % ARCMSR_MAX_QBUFFER;
WARNING: line over 80 characters
#93: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:140:
+ memcpy(&acb->rqbuffer[0], temp, rqbuf_lastindex);
WARNING: line over 80 characters
#96: FILE: drivers/scsi/arcmsr/arcmsr_attr.c:143:
+ rqbuf_lastindex = (rqbuf_lastindex + data_len) % ARCMSR_MAX_QBUFFER;
WARNING: Too many leading tabs - consider code refactoring
#225: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:771:
+ } else if ((temp & 0x01) == 0
WARNING: line over 80 characters
#228: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:774:
+ scsi_device_lookup(acb->host,
WARNING: Too many leading tabs - consider code refactoring
#230: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:776:
+ if (psdev != NULL) {
WARNING: line over 80 characters
#231: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:777:
+ scsi_remove_device(psdev);
WARNING: line over 80 characters
#232: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:778:
+ scsi_device_put(psdev);
WARNING: line over 80 characters
#328: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1549:
+ while ((doneq_index & 0xFFF) != (outbound_write_pointer & 0xFFF)) {
WARNING: line over 80 characters
#339: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1556:
+ (index_stripped | 0x4000) : (index_stripped + 1);
WARNING: line over 80 characters
#349: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1563:
+ index_stripped ? index_stripped : ((index_stripped | 0x4000) + 1);
WARNING: line over 80 characters
#354: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:1567:
+ pmu->done_qbuffer[doneq_index & 0xFFF].addressLow;
WARNING: braces {} are not necessary for single statement blocks
#420: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2145:
+ if (!vaddr) {
+ goto leave;
+ }
WARNING: labels should not be indented
#460: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2183:
+ leave:
WARNING: Too many leading tabs - consider code refactoring
#506: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2223:
+ if ((acb->wqbuf_lastindex
WARNING: Too many leading tabs - consider code refactoring
#515: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2232:
+ } else {
WARNING: line over 80 characters
#516: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2233:
+ memcpy(iop_data, pQbuffer,
WARNING: line over 80 characters
#518: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2235:
+ - acb->wqbuf_firstindex);
WARNING: line over 80 characters
#593: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2308:
+ arcmsr_iop_message_wrote(acb);/*notice IOP the message has been written*/
WARNING: line over 80 characters
#646: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2495:
+ ? (index_stripped | 0x4000) : (index_stripped + 1);
WARNING: line over 80 characters
#654: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2501:
+ ? index_stripped : ((index_stripped | 0x4000) + 1);
WARNING: line over 80 characters
#727: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2728:
+ &acb->wqbuffer[acb->wqbuf_firstindex];
WARNING: Too many leading tabs - consider code refactoring
#728: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2729:
+ if (acb->wqbuf_firstindex + 4 >
WARNING: line over 80 characters
#730: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2731:
+ memcpy(iop_data, pQbuffer,
WARNING: line over 80 characters
#731: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2732:
+ ARCMSR_MAX_QBUFFER - acb->wqbuf_firstindex);
WARNING: line over 80 characters
#732: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2733:
+ iop_data += ARCMSR_MAX_QBUFFER
WARNING: line over 80 characters
#734: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2735:
+ acb->wqbuf_firstindex += 4;
WARNING: Too many leading tabs - consider code refactoring
#742: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2743:
+ } else {
WARNING: line over 80 characters
#743: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2744:
+ if ((acb->wqbuf_lastindex -
WARNING: Too many leading tabs - consider code refactoring
#743: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2744:
+ if ((acb->wqbuf_lastindex -
WARNING: line over 80 characters
#744: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2745:
+ acb->wqbuf_firstindex) > 4) {
WARNING: line over 80 characters
#747: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2748:
+ acb->wqbuf_firstindex
WARNING: line over 80 characters
#749: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2750:
+ acb->wqbuf_firstindex
WARNING: line over 80 characters
#750: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2751:
+ %= ARCMSR_MAX_QBUFFER;
WARNING: Too many leading tabs - consider code refactoring
#752: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2753:
+ } else {
WARNING: line over 80 characters
#755: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2756:
+ acb->wqbuf_lastindex
WARNING: line over 80 characters
#756: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2757:
+ - acb->wqbuf_firstindex);
WARNING: line over 80 characters
#758: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2759:
+ acb->wqbuf_lastindex
WARNING: line over 80 characters
#759: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2760:
+ - acb->wqbuf_firstindex;
WARNING: line over 80 characters
#760: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2761:
+ acb->wqbuf_firstindex
WARNING: line over 80 characters
#761: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2762:
+ = acb->wqbuf_lastindex;
WARNING: line over 80 characters
#782: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2783:
+ &acb->wqbuffer[acb->wqbuf_firstindex];
WARNING: Too many leading tabs - consider code refactoring
#783: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2784:
+ if ((acb->wqbuf_lastindex -
WARNING: Too many leading tabs - consider code refactoring
#792: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2793:
+ } else {
WARNING: line over 80 characters
#793: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2794:
+ memcpy(iop_data, pQbuffer,
WARNING: line over 80 characters
#795: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2796:
+ - acb->wqbuf_firstindex);
WARNING: line over 80 characters
#825: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2826:
+ allxfer_len += acb->wqbuf_lastindex
WARNING: printk() should include KERN_ facility level
#874: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2867:
+ printk("%s: ARCMSR_MESSAGE_FAIL!\n", __func__);
WARNING: printk() should include KERN_ facility level
#890: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2879:
+ printk("%s: memory not enough!\n", __func__);
WARNING: line over 80 characters
#953: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2935:
+ acb->rqbuf_lastindex - acb->rqbuf_firstindex);
WARNING: line over 80 characters
#982: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2950:
+ data_len_residual = data_len = readl(&prbuffer->data_len);
WARNING: braces {} are not necessary for single statement blocks
#985: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2953:
+ if (!vaddr) {
+ goto leave;
+ }
WARNING: labels should not be indented
#1025: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2992:
+ leave:
WARNING: line over 80 characters
#1029: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:2994:
+ memcpy(pcmdmessagefld->messagedatabuffer, ver_addr, allxfer_len);
WARNING: line over 80 characters
#1093: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3046:
+ pQbuffer = &acb->wqbuffer[acb->wqbuf_lastindex];
WARNING: line over 80 characters
#1099: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3052:
+ ptmpuserbuffer += (ARCMSR_MAX_QBUFFER
WARNING: line over 80 characters
#1107: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3060:
+ acb->wqbuf_lastindex += user_len;
WARNING: printk() should include KERN_ facility level
#1282: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3210:
+ printk("unknown controlcode(%d)\n", __LINE__);
WARNING: line over 80 characters
#1354: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:3957:
+ pmu->doneq_index = index_stripped ? (index_stripped | 0x4000)
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 74 warnings, 1349 lines checked
../patch5 has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
next reply other threads:[~2013-02-08 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 6:03 NickCheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-08 6:04 NickCheng
2013-02-06 8:38 NickCheng
2012-12-04 12:02 NickCheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5741810F8C904659B2563B4E3058B701@arecaaebe11fae \
--to=nick.cheng@areca.com.tw \
--cc=ching2048@areca.com.tw \
--cc=jejb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®