From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbeAYTou (ORCPT ); Thu, 25 Jan 2018 14:44:50 -0500 Received: from mail-ve1eur01on0135.outbound.protection.outlook.com ([104.47.1.135]:35808 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751108AbeAYTos (ORCPT ); Thu, 25 Jan 2018 14:44:48 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v5 1/2] mm/memcontrol.c: try harder to decrease [memory,memsw].limit_in_bytes To: Andrew Morton Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Michal Hocko , Johannes Weiner , Vladimir Davydov References: <20171220102429.31601-1-aryabinin@virtuozzo.com> <20180119132544.19569-1-aryabinin@virtuozzo.com> From: Andrey Ryabinin Message-ID: <5741fb29-a343-1f20-8957-bcd3647f2111@virtuozzo.com> Date: Thu, 25 Jan 2018 22:44:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180119132544.19569-1-aryabinin@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [84.47.128.244] X-ClientProxiedBy: DB6PR1001CA0038.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::24) To VI1PR08MB2831.eurprd08.prod.outlook.com (2603:10a6:802:19::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af30d40f-7857-4a66-f9eb-08d5642c15ac X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:VI1PR08MB2831; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;3:rGWEQKDUDeMY8FHo+oGr3SCuxW3YRks/7JT6gShyBDBSyR9I+1Wl0YQrQ8//fVoX2JfXdbsLaiY6SB7i36OCiSkBH3SUOd8xDXs2mvz9ZzW/JeSY5+hqnhr6VNOlPZUgpYuk7HESJE7VUDBdR3u13JYgnhQHEDz7iubABjM+kTS43KD2a7r3k9ADi6+h3xyC4QHFnWaChZ2ff4bUjcrBY4iHl5+Yxr98QrnUfeSHZqJ0brKtzVhEGO7gK88IlACY;25:iYDQ/UN25HtAVTW+tLTcslAFHnKruRvaK/yv5ore7ADq2cvwKPFbMxxThRm55/hA1aruGWlLrSyFxxLYTCTcbNZA2p5FgcntqXIh/9CdxshI99Rl/oDDxgSALEtpC5hl9RCpew/R44B/LyqWF7GdbELj+K/QK0pbov7BMDfaRBOq0TJ2wr07N/2xdbHvVKSGuWA7YJ1lBff0l5hLfNBp/SmT/I+tmqKSouDY00OVnsmj3IYn3DGHAUwTeWVLg69feQIEqv2gB0eHgHl4yKMg5MmEzeFqo/7u1pHQP00ojZpo0GbVKkNvfiGNffAc2Q+qXNcCXmE8N7O/cpOScACGlA==;31:yIYiShZ5E5Winxdu5uFl8o5nDAfvzP5FSdZ7IOK2rZiC/pQCZfqPD2SzOqlY9i2Cdyb0mOHtkMGL+G/jI/xCS40g2KW//MCTmRLvypCaXyfuYhZ1eOUoSTsU1dbKT8+p2mnfWh9PSq7ZFYYB7WKk8JMmxu0BOD3lm/YjvzKqppqUZN3Y/1lnP3Gbw/weE0mqige2Rp0qJyHQxemoy8zqUkFyIOYfhjE22bso/cfo4YA= X-MS-TrafficTypeDiagnostic: VI1PR08MB2831: X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;20:Y9zv3QMLKL+fzgYM0RN0qBeupCgm2EwAskfFjOe/U9segxvcK/nD+esZOLpKvQg+kNMQDS6haQr7tv8Cd1ckKaMJnnJ9GwkKapZYPCXewwA0QrQxgFWFl6Mrh8gIVDeSV0YEFxfcavVhUx2dTIewb+2p+vnwTlYiWYY9RaKX86OLIKOreVkhIaeBaP55mhNnDIywOe6MtIc4RPKhycpdzcv+S29GU5sfqOutLMeliQeTBFGuRtwvVz6I/2pMZk0DJu6FI+sU+frumMe3i2CffYOap5Mq76dO50Kr6BInxuNwGwTaqaP65y4fq+kakxGthgukJQj+Ll1b+FSUGJ/Z2wpzsGg7S9oaKMftrMjwFX4yyGin6QMRuqXzjg6O3ppXPYwTH6hcHsKJMvQ1YiKcUplbVwUQX3lhuvTIFPyxChI=;4:cuZtg6udjIO5vqKPwzkEWIZB+I4/A9kBdXUr0UR6ciMfeg72a7Ry6GYwhRvOV9cX1lrtpUrkoNdKhPs2G0Bk99Ddc9sKM8FnKHwy5OmlWWTnkRtBq5QH5Cur/8Z7FJUyjBlMPYBRXiAAb7z0RYXrmL8VR1J43O7jz3FdVP0FCCenXuyZKCpzoe53zFBHOAzfIuI/qW+pvWNlhAg572pp14l4ReHFzZpdjNpznGOoShFwGjhXJXDhyai8a6lul6xcx3do+Uh/Gbex8eLfS4/IH2uRyKwTXOxdBrY9EEdLUgUAXgNCLbSX7S5X/w2cdrXVSg31g1FJImTLhqgFiOvwzhgLEZNGuvhID9eatPReoYz5IwUd9y70z7smQLh9oggr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(211936372134217)(153496737603132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(3002001)(10201501046)(93006095)(93001095)(6041288)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:VI1PR08MB2831;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB2831; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(366004)(376002)(39380400002)(346002)(396003)(39850400004)(189003)(199004)(50466002)(77096007)(83506002)(31696002)(47776003)(16526018)(26005)(3846002)(6116002)(305945005)(65806001)(66066001)(65956001)(230700001)(64126003)(478600001)(2486003)(52116002)(186003)(25786009)(16576012)(7736002)(52146003)(23676004)(65826007)(5660300001)(2906002)(54906003)(31686004)(386003)(53546011)(58126008)(59450400001)(6246003)(86362001)(39060400002)(6666003)(97736004)(106356001)(36756003)(53936002)(6916009)(105586002)(4326008)(68736007)(8676002)(6486002)(81156014)(316002)(76176011)(2950100002)(81166006)(8936002)(229853002)(34023003)(148693002)(142933001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB2831;H:[10.52.82.100];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4TUIyODMxOzIzOjhVM3JaR2trTU9QRnNoaVdwdFJRMkhuYkJh?= =?utf-8?B?ejR2ZXVOdVBPVU1VTzdHQ1VkaDhXdzh1aklMZm5Yd3AwbUVpd1dZVy9MZGpN?= =?utf-8?B?bmpjZnVNeDhmajFEYTdDRGFZaVUwUTdZUDdrSnhrK2t6VmhkSDUvUk5HSUcv?= =?utf-8?B?YmxQMUdMVTdJWXg1VG42VmRhWTd2a2ppTFpLdkFVTldTQUpMQkRZUXBrR0xi?= =?utf-8?B?cEJUQzJCcU9WenJWYkxsUkFCRFNuaHdmY1lXMnM1ZjlXV252UmpUS1lFWExC?= =?utf-8?B?KzRubUJjbEk5MUhSRitZOWdpcDVDNkVib1dBVWwzeUpMNFlnUE04Nk5FOE1B?= =?utf-8?B?TDZGa1M1eDY1cVhZU3ZWSncwU2p2SkRiRWNNeXlnYXBqNVRPdWE1empub28r?= =?utf-8?B?cFZKUHFIM1MrdCtNNk4wdG84UXc2NStMRGlWUnp5dU5UZ0N3aWttRk9neW9m?= =?utf-8?B?OUlETXRvSWNCSmhhcDZUTmw0ajdoR2VPSzlJTmZDUEJxdW1UUnhpUDRsUHB0?= =?utf-8?B?cTlJbGl6a05wdjVzWVpDQWxOdHlZVkI4Y2lrSzZkQkVZL0JISjdKTTZvTlcz?= =?utf-8?B?RC94SE0rZjcyelJlQ3oxb0syNkdST3BqdTF1SSt2Zi82OTExemNDbXZLaEJr?= =?utf-8?B?bmlLRStqd0lVSmNLSklPR0szSk16RVgwSzJhVlkveG5TZmkvL0dsZmdvSGI5?= =?utf-8?B?enRaMHY5SlFkQ1cwbnVGWEE0S05NVDlWMnBIbEdrYVJaaDZRR0xJa1B5UWxV?= =?utf-8?B?NGEvYnltT1RGUVp5K0F1OFVHOTVWRGU0RUoyVU96QXgrTVJ1VmZuM0RJRDMr?= =?utf-8?B?NFRWZkRlTVlaNG5weE9PUWdSZE4xcURsTzZkckxoRW1YL25ueFBBeUJFL1lV?= =?utf-8?B?aDRWQ0FKMEg0N2Q4V3U4a25JaTZueWFnTlh1YzBGZ25UR1pvaHZ6YnJpSG56?= =?utf-8?B?czR5Ym56c3N0UnVLYzlUV2JtcVczd05aSVI4OU1pbUZVWmtvckJibGtybEpw?= =?utf-8?B?RjVWMFBZSnBvUnovcEllSklkRkNCQnN0Sm9tR0lyMWlueUplN1lYZTZHZ3Z2?= =?utf-8?B?d0wvTi9WY2JhV0tuWEh0b3k1ZCtLSHNBcFI3SG5zdEhVM0YvbWZiUE1sMStr?= =?utf-8?B?QWE3enJteVFYOEh4cHBqM3FRZzM1MTZxS2N2Y2IvZS9vSVY3VnVPUWVUUXZh?= =?utf-8?B?Ylg3TnA4NVdXZHpuUHB1U0FheVh1cHZVQmt4MHpueGg5a1ZBS2ZGUmRxbnRE?= =?utf-8?B?MVVpdjRqVS8yckVDZTdGOE1kc0M2bzl6ZytrQWMxRU1OaUpJMTdKQmdXSHVS?= =?utf-8?B?OWhZZ1YyQzVsWEtISFpLZE1zMitINmZud0RKUUtaS21IdktFcDRlRXNPSllj?= =?utf-8?B?M1VwY0FVc0ZueE1rcGJFaDhFQkZoUU42NzdQSHMvT1REVFJVZlVUcFp2RUEr?= =?utf-8?B?VldyUXlUOGRRcFp0MzJlU0xXV2Q4OGg0QWplbDVqNjcrN0UxWFNSS3dBL1JH?= =?utf-8?B?VjN3UURPaTIydWhFSklGemI2K3pXL3NqRlJFemwyRjRQUDEzazY5R1A3d3pq?= =?utf-8?B?Nld0N1NLWTc0SmFHZ0IzUlM2YnpaTmZGb2E3RzNZRDg2N2NkNmJRUzJQRjIz?= =?utf-8?B?dHRlTXBhYStlYmhXa0srbmRYcmRHM1djM2FPUEp1aXRheFpzTWpFMVdvNUIw?= =?utf-8?B?QjdvbHNZbGkzcDFMTlk4bWVSbnVEd25jcEo5ekZpNmNLem9ZNjM4UlJWR013?= =?utf-8?B?VXZacHdzQ3dZN055OTliUUF0RkNwWk4zWlZSaU9wdWpnb0RsWmtiaHZlTi8r?= =?utf-8?B?TDBDV3VpYnhGOVZOcEpkQk5CWmxUc3VjNUM4NDRzOVJWdzVnanppWnJWQ1VI?= =?utf-8?B?MmV5L3p6dSs1c1NiUFV4elB2TFdyaytFR2hsRXFSeWpKMldYY1A2WWE5SFU5?= =?utf-8?B?dXlQdm8wMzZ0SUF2WUJmZmJLV0Jpb3hzYTVZUEwyMVpjYkM4YkZZdkNQRlVT?= =?utf-8?B?cnFob2czbkxYcWluVmRNbEkwT2JBM3dZZTNPd09SY2ZIam9KSGI5ZzFZTEJC?= =?utf-8?Q?St7E=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;6:XGF4MQTzYEzZ8sd+fXFkxtO6Wxl8Gi3MlzYAO9/HwwIHZLuKJYd2BJIgSihvtyAirfIjj3phOWAjCJd5xpaO/naQdd21jPYbE7ygFmwxN1oRwP8RwDhhP/xzdaQQDeNJgIU7lFeFpEUhnQ3yAJRsj28HizT1zWXsyyygWGq7CepRCh1/2+eFngettdObwlM4XidBofj/j61bO9HZOrmjg3DggeNuCCPFZeN4FxvKMEVGJdVy1oWsKCdU6zALFYbVJgUxDY4OCniiPSofavs/fHFvgawRtsR66yGSjc/4Zfx0hQYwLYIQ0eVGrTiJCgt0Ub8CQVneziCmme5ov2xRCRlGJHrY7g0AHElMw8NZJlg=;5:mBbFe8WoCRCiOvIafXec84/8trY74k3IorBwwEz9dFSYIKyc+3WLpJyl47Q43MMPF5U+YfFK5okS2tD23DIQdDFMaycsKYWl7ObZCC0ZDzU5A+u9qj1qsKPJ0oXWpEn//VJkgXSgobK3r96dTugbtEvAqV88iapeFZP6601Rzfw=;24:bi3qbIvot1IELm1UoMuphHM4uByjti6+ZmyMvbhZmj+Mdp0y+tY1Pwam+6Wfvf4UiV5qoNeORiBiQ1h2Ij2qwG6pRA3tIKeo6ykYOC38JtU=;7:l7YkUY1tNEX5BV6B1ESovqafolsM1vK2++7+M0k0M66c1+9hSsMovFMZF1R+c2uwdFo2px8F/0drysqbPioNhQ/nwhSOthb3XvX6eeiK0hsN9EyS7viZ3gGiBLNtEcIaSBliqJ16RnJ1Zj0hdqeTl2BEEDfSMXqj9x+WHraAdeDYZm/EqD/yKPxu+0ABhpAMghjlUk8bfZ7T//mm8rVX8gwIw6QLDZ374+/6hfaanBrxRFylyYec1PUutuJFFcGJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;20:If97w7tmztuilWqdZb42lOLqJSMjvSke+m2LDLuOlG2RXEYorS1UBXy7Fg19oi5QlzWouOkFUm6WIzznSmTIHy+B9zJp+o/SMgroq+1nEOuzwyqVD3t4RpgrWLZW8HfNNH+Jqo2nOsftkbg05KFa8F/Fw/0TkNcwGim99rKqyCk= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 19:44:43.6226 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af30d40f-7857-4a66-f9eb-08d5642c15ac X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2831 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2018 04:25 PM, Andrey Ryabinin wrote: > mem_cgroup_resize_[memsw]_limit() tries to free only 32 (SWAP_CLUSTER_MAX) > pages on each iteration. This makes it practically impossible to decrease > limit of memory cgroup. Tasks could easily allocate back 32 pages, so we > can't reduce memory usage, and once retry_count reaches zero we return > -EBUSY. > > Easy to reproduce the problem by running the following commands: > > mkdir /sys/fs/cgroup/memory/test > echo $$ >> /sys/fs/cgroup/memory/test/tasks > cat big_file > /dev/null & > sleep 1 && echo $((100*1024*1024)) > /sys/fs/cgroup/memory/test/memory.limit_in_bytes > -bash: echo: write error: Device or resource busy > > Instead of relying on retry_count, keep retrying the reclaim until the > desired limit is reached or fail if the reclaim doesn't make any progress > or a signal is pending. > > Signed-off-by: Andrey Ryabinin > Cc: Shakeel Butt > Cc: Michal Hocko > Cc: Johannes Weiner > Cc: Vladimir Davydov Andrew, are you ok to pick up the patch?