From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753035AbcEWF26 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 May 2016 01:28:58 -0400
Received: from arroyo.ext.ti.com ([198.47.19.12]:37336 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752829AbcEWF25 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 May 2016 01:28:57 -0400
Subject: Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init
 fails
To: Axel Lin <axel.lin@ingics.com>
References: <1463980885.4421.1.camel@ingics.com>
CC: Anup Patel <anup.patel@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        <linux-kernel@vger.kernel.org>
From: Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <57429513.8040701@ti.com>
Date: Mon, 23 May 2016 10:58:51 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1463980885.4421.1.camel@ingics.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Monday 23 May 2016 10:51 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

however obvious the patch maybe, it's nice to add a little commit log.

Thanks
Kishon
> ---
>  drivers/phy/phy-brcm-sata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
> index 6c4c5cb..5d7fad4b 100644
> --- a/drivers/phy/phy-brcm-sata.c
> +++ b/drivers/phy/phy-brcm-sata.c
> @@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
>  		rc = -ENODEV;
>  	};
>  
> -	return 0;
> +	return rc;
>  }
>  
>  static const struct phy_ops phy_ops = {
>