From: Jens Axboe <axboe@kernel.dk>
To: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes]
Date: Wed, 30 Jun 2021 14:38:34 -0600 [thread overview]
Message-ID: <5742bdb2-6d99-f32d-33a2-b9c5f51e9345@kernel.dk> (raw)
In-Reply-To: <20210630203720.208003-1-abd.masalkhi@gmail.com>
On 6/30/21 2:37 PM, Abd-Alrhman Masalkhi wrote:
> In the first patch I have not defined the print_disk_stats function
> static so it triggered an [-Wmissing-prototypes] warning, fixing it
> by defineing the function static.
Just send a v2 of the patch, there's no point in applying a known
broken patch to then just do a followup of it.
--
Jens Axboe
prev parent reply other threads:[~2021-06-30 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 20:37 Abd-Alrhman Masalkhi
2021-06-30 20:38 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5742bdb2-6d99-f32d-33a2-b9c5f51e9345@kernel.dk \
--to=axboe@kernel.dk \
--cc=abd.masalkhi@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®