From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755717AbcE0AxW (ORCPT ); Thu, 26 May 2016 20:53:22 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:56405 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755561AbcE0AxU (ORCPT ); Thu, 26 May 2016 20:53:20 -0400 X-AuditID: cbfee68e-f79b26d0000013da-b8-57479a7e2388 Message-id: <57479A7E.3050103@samsung.com> Date: Fri, 27 May 2016 09:53:18 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , linux-rockchip@lists.infradead.org Subject: Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit References: <1464232063-24841-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1464232063-24841-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsWyRsSkWLdulnu4weG/LBZnlx1ks7i8aw6b xZH//YwWnx78Z7a482Q9q8XxteEObB6zGy6yeNy5tofNY/OSeo+/s/azeHzeJBfAGsVlk5Ka k1mWWqRvl8CV8X3CXOaCR+wVV46ZNTDOY+ti5OSQEDCR6J98iR3CFpO4cG89UJyLQ0hgBaPE manL4YreTHjNBJGYxSixbvYsRgjnAaPEin8fWUGqeAW0JD6cnwc2ikVAVWLqr8VgNpuAjsT2 b8eZQGxRgTCJB+v2QtULSvyYfI8FxBYR8JPYumMr2GpmgQ5GiWcrpoIlhAVCJRb/2coOsW0e o8SUlefAujkFPCUaP68EmsoB1KEncf+iFkiYWUBeYvOat8wQZx9jl9j6ww7iIAGJb5MPsYCU SwjISmw6AFUiKXFwxQ2WCYxis5CcNAth6CwkQxcwMq9iFE0tSC4oTkovMtIrTswtLs1L10vO z93ECIyz0/+e9e1gvHnA+hCjAAejEg8vg7N7uBBrYllxZe4hRlOgIyYyS4km5wOjOa8k3tDY zMjC1MTU2Mjc0kxJnDdB6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBkaxlYbF243uMc8N rFUL+Kax78HvWZfys6/3LzaylPj+KLLSzJJ7TnOLnWpo0BkjIf2nlt/XPPmR0Wk2k+MRG2+r 6AfLqof3i5tyXApY6+9POzRxJ2NcUkC540oP7bzaviDedqsFtf8bp20PYkw8rdyzJOVxYbvS 7XOarg5V5qWTGgJ51j67oMRSnJFoqMVcVJwIAACCB+WuAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jQd26We7hBi8ELc4uO8hmcXnXHDaL I//7GS0+PfjPbHHnyXpWi+Nrwx3YPGY3XGTxuHNtD5vH5iX1Hn9n7Wfx+LxJLoA1qoHRJiM1 MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdov5JCWWJOKVAo ILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx4/uEucwFj9grrhwza2Ccx9bFyMkhIWAi 8WbCayYIW0ziwr31QHEuDiGBWYwS62bPYoRwHjBKrPj3kRWkildAS+LD+XnsIDaLgKrE1F+L wWw2AR2J7d+Og00SFQiTeLBuL1S9oMSPyfdYQGwRAT+JrTu2gm1gFuhglHi2YipYQlggVGLx n63sENvmMUpMWXkOrJtTwFOi8fNKoKkcQB16EvcvaoGEmQXkJTavecs8gRHoToQdsxCqZiGp WsDIvIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOJafSe1gPLjL/RCjAAejEg8vg7N7 uBBrYllxZe4hRgkOZiUR3s0zgUK8KYmVValF+fFFpTmpxYcYTYGBMJFZSjQ5H5hm8kriDY1N zIwsjcwNLYyMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwMhjv3t278ruKc5HxVk2xnD0 JV5PPCX2h+3MNobH4Vkb7l7uk9xwP+3f4/ZvykvmKq3Lnpy9x32d4PxolSUn1NUmzpe7eeD9 QfnNTFNOzLrH/7rC/17+v6CrD0Xzwx/Gndhfk+TfP+/f4fY+MYt9bx0MWcLVjAwnu56O8v3R v2HzcY6Zqgc39IsrsRRnJBpqMRcVJwIAsbDRmPsCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 05/26/2016 12:07 PM, Shawn Lin wrote: > dw_mci_get_cd have already dealed with these for > both of internal card-detect and gpio card-detect. s/dealed/dealt This patch looks good to me. Could you resend the patch? not RFC. Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > > --- > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 829a6ee..cb30e91 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > mmc->max_seg_size = mmc->max_req_size; > } > > - if (dw_mci_get_cd(mmc)) > - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); > - else > - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + dw_mci_get_cd(mmc); > > ret = mmc_add_host(mmc); > if (ret) >