From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756568AbcE0SfZ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 14:35:25 -0400
Received: from avon.wwwdotorg.org ([70.85.31.133]:45496 "EHLO
	avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756306AbcE0SfV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 14:35:21 -0400
Subject: Re: [PATCH] arm: tegra124: remove commas from unit addresses
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
References: <1464366471-23832-1-git-send-email-marcel.ziswiler@toradex.com>
Cc: devicetree@vger.kernel.org, Thierry Reding <thierry.reding@gmail.com>,
        Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        linux-tegra@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org
From: Stephen Warren <swarren@wwwdotorg.org>
Message-ID: <57489360.1030300@wwwdotorg.org>
Date: Fri, 27 May 2016 12:35:12 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1464366471-23832-1-git-send-email-marcel.ziswiler@toradex.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
> Remove commas from unit addresses as suggested by Rob Herring upon me
> posting initial Apalis TK1 support:
>
> http://article.gmane.org/gmane.linux.ports.tegra/26608

> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts

> -	gpu@0,57000000 {
> +	gpu@57000000 {
>   		/*
>   		 * Node left disabled on purpose - the bootloader will enable
>   		 * it after having set the VPR up

The last time a similar patch was proposed[1], I pointed out that U-Boot 
uses the node name to enable the node, so this change will break GPU 
functionality on this board. U-Boot has since been updated to find the 
node to enable using compatible value rather than hard-coding the node 
name, but this doesn't help people with existing bootloader binaries; 
kernel changes shouldn't force them to upgrade the bootloader. I think 
the DT node names are part of the ABI and shouldn't be changed. We can 
fix this for completely new SoCs, but not existing SoCs.

[1] http://www.spinics.net/lists/devicetree/msg122164.html "[PATCH] ARM: 
tegra: Remove 0, prefix from unit-addresses".