From: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
lukasz.luba@arm.com, konradybcio@kernel.org, amitk@kernel.org,
mani@kernel.org, casey.connolly@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 2/8] remoteproc: qcom: probe all child devices
Date: Fri, 23 Jan 2026 19:23:39 +0530 [thread overview]
Message-ID: <57493aef-fb35-4377-8cf3-1df7f53470c9@oss.qualcomm.com> (raw)
In-Reply-To: <cb5430c8-12d6-4439-b1ae-c2f36f29a9f8@oss.qualcomm.com>
On 1/8/2026 12:37 PM, Gaurav Kohli wrote:
>
> On 1/3/2026 8:26 PM, Bjorn Andersson wrote:
>> On Tue, Dec 23, 2025 at 06:02:21PM +0530, Gaurav Kohli wrote:
>>> From: Casey Connolly <casey.connolly@linaro.org>
>>>
>>> Generalise the qcom,bam-dmux child node support by probing all
>>> remoteproc children with of_platform_populate(). This will be used to
>>> enable support for devices which are best represented as subnodes of
>>> the
>>> remoteproc, such as those representing QMI clients.
>> Please flip this around, start with the description of the problem
>> you're trying to solve.
>>
>>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>> This must have your signed-off-by, where you certifies the origin of
>> this patch.
>>
>>> ---
>>> drivers/remoteproc/qcom_q6v5.c | 4 ++++
>>> drivers/remoteproc/qcom_q6v5_mss.c | 8 --------
>>> 2 files changed, 4 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/drivers/remoteproc/qcom_q6v5.c
>>> b/drivers/remoteproc/qcom_q6v5.c
>>> index 58d5b85e58cd..a02839c7ed8c 100644
>>> --- a/drivers/remoteproc/qcom_q6v5.c
>>> +++ b/drivers/remoteproc/qcom_q6v5.c
>>> @@ -6,6 +6,7 @@
>>> * Copyright (C) 2014 Sony Mobile Communications AB
>>> * Copyright (c) 2012-2013, The Linux Foundation. All rights
>>> reserved.
>>> */
>>> +#include <linux/of_platform.h>
>>> #include <linux/kernel.h>
>>> #include <linux/platform_device.h>
>>> #include <linux/interconnect.h>
>>> @@ -351,6 +352,8 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5,
>>> struct platform_device *pdev,
>>> return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path),
>>> "failed to acquire interconnect path\n");
>>> + of_platform_populate(q6v5->dev->of_node, NULL, NULL, q6v5->dev);
>> There are other child nodes here, in particular the GLINK and SMD edges.
>> Do we really want platform_devices registered for them?
>>
>> Regards,
>> Bjorn
>
>
> thanks for pointing this, can you please suggest the right approach.
>
> This should not impact glink, as that is registering as rproc sub
> node, And we need rproc cooling as child node
>
> of remote proc subsytem to create probe dependency only.
>
>
> Can we do platform populate for specific child, would that be right
> approach. or we should create rproc cooling as independent of parent ?
>
HI Bjorn,
I’d like to highlight the impact and details of placement of remoteproc
cooling dt node:
->As a child of the remote proc subsystem node:
In this configuration, the cooling device will only be probed once
the corresponding remote proc subsystem itself is probed.
->Outside the remote proc subsystem, may be part of soc node:
In this setup, the cooling device will be probed independently. It
will wait until the remoteproc subsystem is brought up
before completing cooling registration.
The drawback here is that if the parent remoteproc subsystem is
disabled, the cooling device will still undergo an
unnecessary probe, even though it cannot be registered.
>
>>> +
>>> return 0;
>>> }
>>> EXPORT_SYMBOL_GPL(qcom_q6v5_init);
>>> @@ -361,6 +364,7 @@ EXPORT_SYMBOL_GPL(qcom_q6v5_init);
>>> */
>>> void qcom_q6v5_deinit(struct qcom_q6v5 *q6v5)
>>> {
>>> + of_platform_depopulate(q6v5->dev);
>>> qmp_put(q6v5->qmp);
>>> }
>>> EXPORT_SYMBOL_GPL(qcom_q6v5_deinit);
>>> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
>>> b/drivers/remoteproc/qcom_q6v5_mss.c
>>> index 91940977ca89..d40565c1cc62 100644
>>> --- a/drivers/remoteproc/qcom_q6v5_mss.c
>>> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
>>> @@ -238,7 +238,6 @@ struct q6v5 {
>>> struct qcom_rproc_pdm pdm_subdev;
>>> struct qcom_rproc_ssr ssr_subdev;
>>> struct qcom_sysmon *sysmon;
>>> - struct platform_device *bam_dmux;
>>> bool need_mem_protection;
>>> bool has_alt_reset;
>>> bool has_mba_logs;
>>> @@ -2029,7 +2028,6 @@ static int q6v5_alloc_memory_region(struct
>>> q6v5 *qproc)
>>> static int q6v5_probe(struct platform_device *pdev)
>>> {
>>> const struct rproc_hexagon_res *desc;
>>> - struct device_node *node;
>>> struct q6v5 *qproc;
>>> struct rproc *rproc;
>>> const char *mba_image;
>>> @@ -2163,10 +2161,6 @@ static int q6v5_probe(struct platform_device
>>> *pdev)
>>> if (ret)
>>> goto remove_sysmon_subdev;
>>> - node = of_get_compatible_child(pdev->dev.of_node,
>>> "qcom,bam-dmux");
>>> - qproc->bam_dmux = of_platform_device_create(node, NULL,
>>> &pdev->dev);
>>> - of_node_put(node);
>>> -
>>> return 0;
>>> remove_sysmon_subdev:
>>> @@ -2186,8 +2180,6 @@ static void q6v5_remove(struct platform_device
>>> *pdev)
>>> struct q6v5 *qproc = platform_get_drvdata(pdev);
>>> struct rproc *rproc = qproc->rproc;
>>> - if (qproc->bam_dmux)
>>> - of_platform_device_destroy(&qproc->bam_dmux->dev, NULL);
>>> rproc_del(rproc);
>>> qcom_q6v5_deinit(&qproc->q6v5);
>>> --
>>> 2.34.1
>>>
next prev parent reply other threads:[~2026-01-23 13:53 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 12:32 [PATCH v1 0/8] Add RemoteProc cooling support Gaurav Kohli
2025-12-23 12:32 ` [PATCH v1 1/8] thermal: Add Remote Proc cooling driver Gaurav Kohli
2025-12-23 19:23 ` Dmitry Baryshkov
2025-12-24 8:20 ` Gaurav Kohli
2026-01-03 15:05 ` Bjorn Andersson
2026-01-05 5:18 ` Gaurav Kohli
2026-01-08 11:59 ` Zhongqiu Han
2026-01-29 5:40 ` Gaurav Kohli
2026-02-02 10:59 ` Lukasz Luba
2026-02-09 5:28 ` Gaurav Kohli
2026-02-09 10:21 ` Lukasz Luba
2025-12-23 12:32 ` [PATCH v1 2/8] remoteproc: qcom: probe all child devices Gaurav Kohli
2025-12-23 19:26 ` Dmitry Baryshkov
2026-01-03 14:56 ` Bjorn Andersson
2026-01-08 7:07 ` Gaurav Kohli
2026-01-23 13:53 ` Gaurav Kohli [this message]
2026-01-23 19:03 ` Dmitry Baryshkov
2026-01-27 16:12 ` Gaurav Kohli
2026-01-27 16:41 ` Dmitry Baryshkov
2026-01-28 9:39 ` Gaurav Kohli
2026-01-28 9:45 ` Konrad Dybcio
2026-01-30 7:03 ` Gaurav Kohli
2026-01-30 9:13 ` Konrad Dybcio
2026-01-31 8:06 ` Dmitry Baryshkov
2026-01-31 10:11 ` Gaurav Kohli
2026-01-31 11:40 ` Dmitry Baryshkov
2026-01-31 11:45 ` Gaurav Kohli
2025-12-23 12:32 ` [PATCH v1 3/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml bindings Gaurav Kohli
2025-12-23 13:59 ` Rob Herring (Arm)
2025-12-24 8:20 ` Gaurav Kohli
2025-12-23 19:30 ` Dmitry Baryshkov
2025-12-24 8:24 ` Gaurav Kohli
2025-12-24 9:31 ` Dmitry Baryshkov
2026-01-03 15:08 ` Bjorn Andersson
2025-12-23 19:52 ` Dmitry Baryshkov
2025-12-24 8:57 ` Krzysztof Kozlowski
2025-12-24 10:08 ` Gaurav Kohli
2025-12-24 10:24 ` Krzysztof Kozlowski
2025-12-31 6:42 ` Gaurav Kohli
2025-12-31 7:35 ` Krzysztof Kozlowski
2025-12-31 7:47 ` Dmitry Baryshkov
2025-12-31 7:52 ` Gaurav Kohli
2025-12-31 7:55 ` Dmitry Baryshkov
2025-12-24 9:02 ` Krzysztof Kozlowski
2025-12-31 11:59 ` Konrad Dybcio
2026-01-08 8:43 ` Gaurav Kohli
2025-12-23 12:32 ` [PATCH v1 4/8] thermal: qcom: add qmi-cooling driver Gaurav Kohli
2025-12-23 19:49 ` Dmitry Baryshkov
2025-12-31 6:28 ` Gaurav Kohli
2025-12-31 6:33 ` Dmitry Baryshkov
2025-12-24 9:01 ` Krzysztof Kozlowski
2025-12-31 6:32 ` Gaurav Kohli
2025-12-23 12:32 ` [PATCH v1 5/8] arm64: dts: qcom: Enable cdsp qmi tmd devices for lemans Gaurav Kohli
2025-12-23 19:32 ` Dmitry Baryshkov
2025-12-23 12:32 ` [PATCH v1 6/8] arm64: dts: qcom: Enable cdsp qmi tmd devices for talos Gaurav Kohli
2026-01-03 15:13 ` Bjorn Andersson
2025-12-23 12:32 ` [PATCH v1 7/8] arm64: dts: qcom: Enable cdsp qmi tmd devices for kodiak Gaurav Kohli
2026-01-03 15:14 ` Bjorn Andersson
2025-12-23 12:32 ` [PATCH v1 8/8] arm64: dts: qcom: Enable cdsp qmi tmd devices for monaco Gaurav Kohli
2025-12-24 8:58 ` Krzysztof Kozlowski
2025-12-24 10:11 ` Gaurav Kohli
2026-01-10 16:13 ` [PATCH v1 0/8] Add RemoteProc cooling support Casey Connolly
2026-01-13 9:33 ` Gaurav Kohli
2026-02-01 20:20 ` Trilok Soni
2026-02-02 9:53 ` Konrad Dybcio
2026-02-09 10:22 ` Gaurav Kohli
2026-02-09 5:33 ` Gaurav Kohli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57493aef-fb35-4377-8cf3-1df7f53470c9@oss.qualcomm.com \
--to=gaurav.kohli@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®