From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E2194779B3 for ; Fri, 15 May 2026 11:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778843641; cv=none; b=XBPV4C7V2oTAZwg1kg6C1r538cdsO2Us9gHLCGknrRzkrg9WIwdZh82SZwMZJvXcgUZ+N8L6mHovPY8OtjvqXxKvCKlarWxfkSjPGovs+fK0RkumC6sAOQaG3NABjpVN/p6pbb7hCaE66UCxIKHmaFC0Pw2AzE/H436Imkce2ks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778843641; c=relaxed/simple; bh=b6fAS5R0MZdbkQE4ZTU8n250+XpH81ELy6U2EHe4pjc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PleGY0MesIMkgei+TLiXwIIUv0AaGXt8wL8dbXoMy1aMu56lLmrus1hIrZfhwrTiplgFdI+csp7Od+gQEtn6TK/q3qF/E13KfFlBqq/BQiWomttCplh+ZDK12evJsPiv3Lhc5fIOSrFUPSHM79x2lhkuVtS8HfuXH3FZm2XszM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BwAAgG6+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hrzy/XzK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BwAAgG6+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hrzy/XzK" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F59I5I3797495 for ; Fri, 15 May 2026 11:13:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qcnnBtD0bTocfS/XZzFNZ3R4W0jt7W/pmdR8q1gCj88=; b=BwAAgG6+1Z5S2VM3 HE74i5ymWDPszaEmGAMUGFOKIxIk0RXFIHG/yIYTe4J1NatFGfPzJnOZ7WPZaACq JOn+l5YLuwUV8U0oaqj2KURGtfAWk7Z7XThmr74utk5v1TV7agetVXdWs4MYM8JD IZKYWFkrVHR6oNuwbto5YgzgwiQwsgT1bbOMJ42a49U3dW+93/GAzvFjoWeYFk8E hdPZDHL4Qm48KhvYd1uAGf4t7CQfEhiPE+0ewAoHD6ri2A8dwfz0YwSMzwj01Ikc UciyrMV1V5a9Ot2gUFS2gHe3V/sfSY+QJNM9qBfQP50e8Bglreu43tUXAufmCuu8 mEAtlQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1stxgg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 11:13:59 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50f1b94ac9dso25878981cf.1 for ; Fri, 15 May 2026 04:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778843639; x=1779448439; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qcnnBtD0bTocfS/XZzFNZ3R4W0jt7W/pmdR8q1gCj88=; b=hrzy/XzKGChT6hZDggt2xYZA9gEdESkE6af5S+tpl5Hxs0sKmUzsbN/alZoT1acELn PJULN9c0UZrvOkmMYDKcCUZnc0gpdkbzG/6AEwJRp7Fyod9SG4Y5jtxcI2kWtHOWY2DP jaG/yU6wSDkMrLK0IMbmiDkb+dvTFDleY0YOnFMwySv19fBdFt6f+6ymubhCm+Kg0OTN G6Dgf8BgbNjxVwtnQx9ACC1LhM4VmzKyY6t563Rz825JhVnSpC/OgSL+xOymYbRgdhXm 287/0MQptNxio7JprU6RAoqu0G7F7eq8tK4sL7Q/hcmfN5uze7vzWvcB+3IFHRERJJkV 87CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778843639; x=1779448439; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qcnnBtD0bTocfS/XZzFNZ3R4W0jt7W/pmdR8q1gCj88=; b=d8qjmgbCAjuY7TAQCY/yWk2U+caSSHXHV/xdnaY7u7oWo/0EO0I3V02yRlw8sfdgQq 9wvLQw+H7AxqDPJqkUEEW2n81WFy95z/V1whQZ45eHmk4yytmpqdnVI4HhTe7YzmaZU8 VqW8rIEJgg7+R/J1c1Gd81Jd0VvINg3pQHQWw03d8MzBLYU9SPx/OSTgJo8FYbZxQicH zk6IJk1UyjFQzbiOroQTqKSsO07Ma5EDjRlRuH6y9bc4dNWyBtFiklicJSQXASfQB7ul bIicWtdUSDDwzRDmoedK8VGbJX5ugdhe/PD6ax1Ym4PfbIy6rwtf7/GH6s932vAC5Qfq q/1A== X-Forwarded-Encrypted: i=1; AFNElJ/VyhF3rSioxYV4FYQ+ON7dsTk2BzTIIJSyuekPMxYUuQXbOGyNmGuAQjlyGtq4TEx3f6xL3GjU1rl7WdI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7aae3kPKmYjT58vHzmzwH1wHhCMvxmO3KOZwsMdVoZaylTQDN ESbtK2O6cZOZVBOLB/+cQY2D33Oivwyk9syfspw2M9pce7vJxm7iiZXrSEYblN5bAOa++Ayf0bh 1pIP/riQqk0snshf0KMnq31rd8+Z4fm3C0NJlShkOQrRkiU8UlEsBAfb6VNFdY4FIYut4ZnRRe6 Y= X-Gm-Gg: Acq92OEASzseXOOXYHMaGhFCCnNOzJKnYcqeeM6akWmz6lzTjPvnsYVgJg60s5ODIRl P6m1zeOC3ixfLoEoJbQrKCDRVbGh0IJBQL3vW0eDuc178a5nJwWkytCu3vWFNUofEn0K8b5X+lb 6MoJvHlCC++aKYTv/hVCESsg5EQIaAO/rfaTiolLrF1hZgM7i6Jf/2Cg7dpf+WGs19brHOgRgt9 /f/ivpTwtfLUEDS7NvOgq2GH9XCVj4QE8B1u9ROYc2RhSmAVXy7LFsZIuzMXm9x4zCHREHd+PVR Nh4tdgIg43ZZ+EJwKlA+ZuTZBNwlGvAgqU1rFQYtJ+HfF9QRqThg1/rBELmk8N8t/DGISaenKjd 0iIwVbmw89VKej70mWGI6+nEpLW/dZJCWJUOR+bFPN3tABe80CDg2J16lxciZl4IJQNTXMi8vM1 /JrMY= X-Received: by 2002:ac8:594d:0:b0:50e:df3b:80 with SMTP id d75a77b69052e-5165a26c9fbmr34330291cf.8.1778843638649; Fri, 15 May 2026 04:13:58 -0700 (PDT) X-Received: by 2002:ac8:594d:0:b0:50e:df3b:80 with SMTP id d75a77b69052e-5165a26c9fbmr34329941cf.8.1778843638214; Fri, 15 May 2026 04:13:58 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6831197bf00sm1883505a12.31.2026.05.15.04.13.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 04:13:56 -0700 (PDT) Message-ID: <574a1ab4-293e-4daf-bad5-8dd886a8178b@oss.qualcomm.com> Date: Fri, 15 May 2026 13:13:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga-c630: lower PSCI cluster idle To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260428-c630-fix-idle-v1-1-29d0da326eb3@oss.qualcomm.com> <57696ca6-42ce-46d6-9b30-cd5ad4378e25@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDExMyBTYWx0ZWRfXwVe+O8crfIeL hGmqofpLH/1T1XsmEi0uIrxYSAo9Cusx5RPnRIbB+QoNFa1/WtaTDpYqiyzsMjeX+u0SyM1b7go vjxJgDPgSvz2as8+W2oNjibHfGgiBcADM47YCO3OPhnAMDkKdanUQrUiYbOsw7bkGZyFjrNMdqO /p9rB6T0YTgmYL/nM/xkCYAe0MvRnuotYuRw8BHGhEu8iDK/paVbgNtwRfVBkh1jCjYwVZm9PrY qf+rhcN/Gd0L6eiFOgZSCKDrB+2/CDbdRrWm2JCHRKmEU74lsJPIEo6Jcr5w13ToAkCYtEIV0C5 /5Aa2evKIjgLrKmw/2YrWD6AZ89KMYQJTVcqFztN0syxDLHm8KRl+tW9kgKJZOM9BMbKBEpRMfT Fjg8x9wpGeQDfuh9X8miDeldk6srzV+GQercsdi6rZ8c9vcDkj1Psv0k0Hn24DXmVgpT5bdfif1 TxXdqhfBgxTz0YdlA6A== X-Authority-Analysis: v=2.4 cv=cZXiaHDM c=1 sm=1 tr=0 ts=6a06fff7 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=DpYfqt6cvqRt1CeACwAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: rhaYE7TWBdaBU04yFWYq7xuRsyrsPw90 X-Proofpoint-ORIG-GUID: rhaYE7TWBdaBU04yFWYq7xuRsyrsPw90 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150113 On 5/15/26 1:09 PM, Dmitry Baryshkov wrote: > On 15/05/2026 14:03, Konrad Dybcio wrote: >> On 5/15/26 1:01 PM, Dmitry Baryshkov wrote: >>> On 15/05/2026 14:00, Konrad Dybcio wrote: >>>> On 4/28/26 9:36 PM, Dmitry Baryshkov wrote: >>>>> With the default PSCI suspend value for cluster idle state Lenovo Yoga >>>>> C630 isn't stable enough. For example it might reset if display device >>>>> isn't probed early enough. Drop one of the bits from the PSCI suspend >>>>> value to make C630 work in stable way. >>>>> >>>>> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI") >>>>> Signed-off-by: Dmitry Baryshkov >>>>> --- >>>>>    arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++++ >>>>>    1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts >>>>> index e41200839dbe..e6c67016552a 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts >>>>> @@ -347,6 +347,10 @@ &cdsp_pas { >>>>>        status = "okay"; >>>>>    }; >>>>>    +&cluster_sleep_0 { >>>>> +    arm,psci-suspend-param = <0x41003244>; >>>>> +}; >>>> >>>> Is it better if you do hack in a >>>> >>>> qmp_send(qmp, "{class: cx_mol, res: cx, val: mol}"); >>> >>> Any clarification? Then I can try hacking it in. >> >> This will send a message to AOSS to intrusct it to prevent CX from >> collapsing > > This sounds like a dirty hack. I think, hacking psci-suspend-param is a lesser evil. Yes, that dirty hack is supposed to help us understand why this is an issue in the first place. Especially since it only came around at some point (although I suppose you're not really happy with spending a day bisecting when exactly) > I know that we should spend time on understanding, what should vote on CX instead, but having the issue only on C630 doesn't really help. Maybe it will go away once I can sort out the gcc / dispcc / mdss issue on SDM845 & SM8150. If it's a "not enough votes" type issue, it can vary from device to device, from unit to unit, depending on your luck in the silicon lottery Konrad