From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756152AbcK2JKu (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Nov 2016 04:10:50 -0500
Received: from mout.kundenserver.de ([217.72.192.75]:61862 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753367AbcK2JKm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Nov 2016 04:10:42 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Hurley <peter@hurleysoftware.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: nozomi: avoid sprintf buffer overflow
Date: Tue, 29 Nov 2016 10:10:34 +0100
Message-ID: <5750086.0s0vVYgDjM@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <3666ac4d-4269-5759-5d0d-1953b16a82b0@suse.cz>
References: <20161128210433.2291532-1-arnd@arndb.de> <3666ac4d-4269-5759-5d0d-1953b16a82b0@suse.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:rM00o94KYAhM2JgeljxGurW2iCTNJXAStiPE25uCjtfcIxHCeFc
 mF25qifwah/smH57pQxxPuSNvOKfKiIXOFH9eYU5yk0T4EbLyRD9m4St7UUzSfuGLrWEZMm
 hGVzZjvG9xtswzLjLh4R6cflpQRpJU381crfm2pH5z9R6XLz5yaVy/PLpFLjNxszEz51SnN
 z5dfVPgKUTlvylhatO7nQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:5Rlxu3REWX0=:BcZsh1Tef4/Mv6BHg7Nxn0
 ivs53eca1Hc2wcC6xXSFNaZkL0O5uQUrDDiasZYK6Y/UUs1xr5BdmgxyYkcAQ3AaiifH+gwcK
 IwuUrzohGOPjAubalgp0Lcjb3HJNvD0X6dCHG2MHRxXbmB7Y4U/vhoPx0zETGyhgOj0HocIm1
 D5u7DoebxHV5XDYZdvJGXDAWouz1+xAtX7NZLjvH+gmu4U89v5GXuTvvZ+lnhVdl0KyQS78tK
 w5h1y9aCDW+JqnyxHXPlNIJhRFU4WcFsZCLXaWRukKnr4kc03b3wecDwHUOuIxmimNrtsOACE
 SRXnP1bOod0hcHksYfL1yPdaztgnRVudKwCr9rB/iF2Kfm22BZl+OPhJ9dtI4DfUmAFUUZmXi
 uQNoN9m+uohw7H+kZjN+ER9E53sC2c5M8Mx+jkj5bx45EbUNKlcRjZ8Rxq+vKmv8mPvSCWtWK
 vELkkdseOvj1N1ja6jLj4AcNsmDVI+vYwlA7jzfNrY54vqviTh8lRgKth3EfCZylYL9URLUyF
 8L9u31epZhD/etFi70ar39o+9Tvnl1UKXQnJ5Hb6CRBnzCm5VSoR3LK54yPtWDzJrLJNFgw/1
 k/CqIgzbmI0sb0BSXkjeWqP7VxJyQ1LoSmdI7Z7OWgg86jZAAo/Mayo2zxtu9ItRefMkuMh/5
 iwg7YNfV3OAKbF9Ipce8FSxq7ie4huKe790Xz7ZL07xQd44XJ11m+phR29UYt5iaqSPoCV4MO
 Gvo94xDVIkoM9k8e
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, November 29, 2016 8:14:32 AM CET Jiri Slaby wrote:
> 
> Could you also kill the now unused _err_flag_ parameter (including the
> only user of NFO)?

Right. I was trying to avoid taking the cleanup too far, lacking
a way to properly test it, but that would have been an obvious change.
 
> (Or inline pr_debug directly into the only user and kill NFO completely?)

I'll send both variants and let you pick one or the other.

	Arnd