Re: [PATCH v6 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250

[Jinlong Mao <quic_jinlmao@quicinc.com>]

Thank you Konrad for the review.

On 4/26/2022 7:49 PM, Konrad Dybcio wrote:
>
> On 25/04/2022 06:03, Mao Jinlong wrote:
>> Add tpdm mm and tpdm prng for sm8250.
>>
>> +---------------+                +-------------+
>> |  tpdm@6c08000 |                |tpdm@684C000 |
>> +-------|-------+                +------|------+
>>          |                               |
>> +-------|-------+                       |
>> | funnel@6c0b000|                       |
>> +-------|-------+                       |
>>          |                               |
>> +-------|-------+                       |
>> |funnel@6c2d000 |                       |
>> +-------|-------+                       |
>>          |                               |
>>          |    +---------------+          |
>>          +----- tpda@6004000  -----------+
>>               +-------|-------+
>>                       |
>>               +-------|-------+
>>               |funnel@6005000 |
>>               +---------------+
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 170 +++++++++++++++++++++++++++
>>   1 file changed, 170 insertions(+)
>
> Hi,
>
>
> some of the previous comments (uppercase hex instead of lowercase and 
> wrong commit title) still haven't been addressed.

I will double check and address your comments.

Thanks

Jinlong Mao

>
>
> Konrad
>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi 
>> b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 53ab2b457a2f..ce558a2639e7 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -4703,6 +4703,73 @@
>>               };
>>           };
>>   +        tpda@6004000 {
>> +            compatible = "arm,primecell";
>> +            reg = <0 0x06004000 0 0x1000>;
>> +            reg-names = "tpda-base";
>> +
>> +            clocks = <&aoss_qmp>;
>> +            clock-names = "apb_pclk";
>> +
>> +            out-ports {
>> +                port {
>> +                    reg = <0>;
>> +                    tpda_out_funnel_qatb: endpoint {
>> +                        remote-endpoint = <&funnel_qatb_in_tpda>;
>> +                    };
>> +                };
>> +            };
>> +
>> +            in-ports {
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +
>> +                port@9 {
>> +                    reg = <9>;
>> +                    tpda_9_in_tpdm_mm: endpoint {
>> +                        remote-endpoint = <&tpdm_mm_out_tpda9>;
>> +                    };
>> +                };
>> +
>> +                port@23 {
>> +                    reg = <23>;
>> +                    tpda_23_in_tpdm_prng: endpoint {
>> +                        remote-endpoint = <&tpdm_prng_out_tpda_23>;
>> +                    };
>> +                };
>> +            };
>> +        };
>> +
>> +        funnel@6005000 {
>> +            compatible = "arm,primecell";
>> +
>> +            reg = <0 0x06005000 0 0x1000>;
>> +            reg-names = "funnel-base";
>> +
>> +            clocks = <&aoss_qmp>;
>> +            clock-names = "apb_pclk";
>> +
>> +            out-ports {
>> +                port {
>> +                    funnel_qatb_out_funnel_in0: endpoint {
>> +                        remote-endpoint = <&funnel_in0_in_funnel_qatb>;
>> +                    };
>> +                };
>> +            };
>> +
>> +            in-ports {
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +
>> +                port@0 {
>> +                    reg = <0>;
>> +                    funnel_qatb_in_tpda: endpoint {
>> +                        remote-endpoint = <&tpda_out_funnel_qatb>;
>> +                    };
>> +                };
>> +            };
>> +        };
>> +
>>           funnel@6041000 {
>>               compatible = "arm,coresight-dynamic-funnel", 
>> "arm,primecell";
>>               reg = <0 0x06041000 0 0x1000>;
>> @@ -4722,6 +4789,13 @@
>>                   #address-cells = <1>;
>>                   #size-cells = <0>;
>>   +                port@6 {
>> +                    reg = <6>;
>> +                    funnel_in0_in_funnel_qatb: endpoint {
>> +                        remote-endpoint = 
>> <&funnel_qatb_out_funnel_in0>;
>> +                    };
>> +                };
>> +
>>                   port@7 {
>>                       reg = <7>;
>>                       funnel0_in7: endpoint {
>> @@ -4836,6 +4910,23 @@
>>               };
>>           };
>>   +        tpdm@684C000 {
>> +            compatible = "arm,primecell";
>> +            reg = <0 0x0684C000 0 0x1000>;
>> +            reg-names = "tpdm-base";
>> +
>> +            clocks = <&aoss_qmp>;
>> +            clock-names = "apb_pclk";
>> +
>> +            out-ports {
>> +                port {
>> +                    tpdm_prng_out_tpda_23: endpoint {
>> +                        remote-endpoint = <&tpda_23_in_tpdm_prng>;
>> +                    };
>> +                };
>> +            };
>> +        };
>> +
>>           funnel@6b04000 {
>>               compatible = "arm,coresight-dynamic-funnel", 
>> "arm,primecell";
>>               arm,primecell-periphid = <0x000bb908>;
>> @@ -4920,6 +5011,85 @@
>>               };
>>           };
>>   +        tpdm@6c08000 {
>> +            compatible = "arm,primecell";
>> +            reg = <0 0x06c08000 0 0x1000>;
>> +            reg-names = "tpdm-base";
>> +
>> +            clocks = <&aoss_qmp>;
>> +            clock-names = "apb_pclk";
>> +
>> +            out-ports {
>> +                port {
>> +                    tpdm_mm_out_funnel_dl_mm: endpoint {
>> +                        remote-endpoint = <&funnel_dl_mm_in_tpdm_mm>;
>> +                    };
>> +                };
>> +            };
>> +        };
>> +
>> +        funnel@6c0b000 {
>> +            compatible = "arm,coresight-dynamic-funnel", 
>> "arm,primecell";
>> +
>> +            reg = <0 0x06c0b000 0 0x1000>;
>> +            reg-names = "funnel-base";
>> +
>> +            clocks = <&aoss_qmp>;
>> +            clock-names = "apb_pclk";
>> +
>> +            out-ports {
>> +                port {
>> +                    funnel_dl_mm_out_funnel_dl_center: endpoint {
>> +                        remote-endpoint = 
>> <&funnel_dl_center_in_funnel_dl_mm>;
>> +                    };
>> +                };
>> +            };
>> +
>> +            in-ports {
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +
>> +                port@3 {
>> +                    reg = <3>;
>> +                    funnel_dl_mm_in_tpdm_mm: endpoint {
>> +                        remote-endpoint = <&tpdm_mm_out_funnel_dl_mm>;
>> +                    };
>> +                };
>> +            };
>> +        };
>> +
>> +        funnel@6c2d000 {
>> +            compatible = "arm,coresight-dynamic-funnel", 
>> "arm,primecell";
>> +
>> +            reg = <0 0x06c2d000 0 0x1000>;
>> +            reg-names = "funnel-base";
>> +
>> +            clocks = <&aoss_qmp>;
>> +            clock-names = "apb_pclk";
>> +
>> +            out-ports {
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +                port {
>> +                    tpdm_mm_out_tpda9: endpoint {
>> +                        remote-endpoint = <&tpda_9_in_tpdm_mm>;
>> +                    };
>> +                };
>> +            };
>> +
>> +            in-ports {
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +
>> +                port@2 {
>> +                    reg = <2>;
>> +                    funnel_dl_center_in_funnel_dl_mm: endpoint {
>> +                        remote-endpoint = 
>> <&funnel_dl_mm_out_funnel_dl_center>;
>> +                    };
>> +                };
>> +            };
>> +        };
>> +
>>           etm@7040000 {
>>               compatible = "arm,coresight-etm4x", "arm,primecell";
>>               reg = <0 0x07040000 0 0x1000>;