From: David Howells <dhowells@redhat.com>
To: Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: dhowells@redhat.com, xiang@kernel.org, chao@kernel.org,
yinxin.x@bytedance.com, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: fix missing xas_retry() in fscache mode
Date: Mon, 14 Nov 2022 11:44:33 +0000 [thread overview]
Message-ID: <575542.1668426273@warthog.procyon.org.uk> (raw)
In-Reply-To: <20221111090813.72068-1-jefflexu@linux.alibaba.com>
Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
> The xarray iteration only holds RCU
I would say "the RCU read lock".
Also, I think you've copied the code to which my dodgy-maths fix applies:
https://lore.kernel.org/linux-fsdevel/166757988611.950645.7626959069846893164.stgit@warthog.procyon.org.uk/
David
next prev parent reply other threads:[~2022-11-14 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 9:08 Jingbo Xu
2022-11-14 4:42 ` Gao Xiang
2022-11-14 6:27 ` [Phishing Risk] [External] " Jia Zhu
2022-11-14 11:44 ` David Howells [this message]
2022-11-14 12:11 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575542.1668426273@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=chao@kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®