From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932422AbdKGK6l (ORCPT ); Tue, 7 Nov 2017 05:58:41 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48236 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbdKGK6j (ORCPT ); Tue, 7 Nov 2017 05:58:39 -0500 Subject: Re: [Patch v12 1/4] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe To: Zhao Qiang , tglx@linutronix.de, jason@lakedaemon.net Cc: linux-kernel@vger.kernel.org References: <20171106053653.23961-1-qiang.zhao@nxp.com> <20171106053653.23961-2-qiang.zhao@nxp.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <5755591c-7632-f3c8-3dc5-2bb842829f13@arm.com> Date: Tue, 7 Nov 2017 10:58:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171106053653.23961-2-qiang.zhao@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/17 05:36, Zhao Qiang wrote: > move the driver from drivers/soc/fsl/qe to drivers/irqchip, > merge qe_ic.h and qe_ic.c into irq-qeic.c. > > Signed-off-by: Zhao Qiang > --- > MAINTAINERS | 6 ++ > drivers/irqchip/Makefile | 1 + > drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 95 ++++++++++++++++++- > drivers/soc/fsl/qe/Makefile | 2 +- > drivers/soc/fsl/qe/qe_ic.h | 103 --------------------- > 5 files changed, 100 insertions(+), 107 deletions(-) > rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (85%) > delete mode 100644 drivers/soc/fsl/qe/qe_ic.h In my previous review of the same patch, I asked for the single-bit constants to be rewritten as BIT(x). You've done none of that. Why? Thanks, M. -- Jazz is not dead. It just smells funny...