From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbcFFNym (ORCPT ); Mon, 6 Jun 2016 09:54:42 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:48636 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcFFNyl convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2016 09:54:41 -0400 Message-Id: <57559CBD02000078000F20EC@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Mon, 06 Jun 2016 07:54:37 -0600 From: "Jan Beulich" To: "Boris Ostrovsky" Cc: "David Vrabel" , "xen-devel" , "Konrad Rzeszutek Wilk" , "Juergen Gross" , Subject: Re: [PATCH 3/2] xen-pciback: drop rom_init() References: <57554B8D02000078000F1DE4@prv-mh.provo.novell.com> <575554CC02000078000F1E3F@prv-mh.provo.novell.com> <5755761D.4020204@oracle.com> In-Reply-To: <5755761D.4020204@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 06.06.16 at 15:09, wrote: > On 06/06/2016 04:47 AM, Jan Beulich wrote: >> It's identical to bar_init() now. >> >> Signed-off-by: Jan Beulich >> --- >> I'm sorry for this 3/2 - I only now noticed that this additional >> simplification is now possible. > > I wonder whether we should also move content of read_dev_bar() into > bar_init(). Especially given that it's not really reading a BAR but > rather initializing the stashed value. I had considered that too, but then thought the splitting out of that logic could as well stay. If we were to do that, I'd in fact prefer merging patches 2 and 3 (plus this additional adjustment). Jan