From: Steve Magnani <steve.magnani@digidescorp.com>
To: Jan Kara <jack@suse.cz>
Cc: Jan Kara <jack@suse.com>,
linux-kernel@vger.kernel.org,
"Steven J . Magnani" <steve@digidescorp.com>
Subject: Re: [PATCH v2 1/3] udf: Fix 64-bit sign extension issues affecting blocks > 0x7FFFFFFF
Date: Mon, 16 Oct 2017 14:20:39 -0500 [thread overview]
Message-ID: <57583a28-5683-a650-7a63-01be73c973df@digidescorp.com> (raw)
In-Reply-To: <20171016141728.GF9762@quack2.suse.cz>
Jan -
On 10/16/2017 09:17 AM, Jan Kara wrote:
> ...
> If you agree with these changes, I'll update your patch and merge it to my
> tree (along with the other two changes which look good to me).
>
>
I think your suggestions are OK. In an ideal world we could work to
reduce the many signed/unsigned conversions, which make me dizzy. I
think the ones that really cause problems are large unsigned int values
which are converted to int and then either to sector_t (except on 32-bit
systems without LBDAF) or to unsigned long on 64-bit systems.
------------------------------------------------------------------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
next prev parent reply other threads:[~2017-10-16 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 13:48 [PATCH v2 0/3] udf: Fix some signed/unsigned conversion issues Steve Magnani
2017-10-12 13:48 ` [PATCH v2 1/3] udf: Fix 64-bit sign extension issues affecting blocks > 0x7FFFFFFF Steve Magnani
2017-10-16 14:17 ` Jan Kara
2017-10-16 19:20 ` Steve Magnani [this message]
2017-10-12 13:48 ` [PATCH v2 2/3] udf: Fix signed/unsigned format specifiers Steve Magnani
2017-10-12 13:48 ` [PATCH v2 3/3] udf: Fix some sign-conversion warnings Steve Magnani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57583a28-5683-a650-7a63-01be73c973df@digidescorp.com \
--to=steve.magnani@digidescorp.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@digidescorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®