From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Will Deacon <will@kernel.org>, Sedat Dilek <sedat.dilek@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [v4] arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for compressed kernel image
Date: Mon, 29 Jul 2024 08:07:55 +0530 [thread overview]
Message-ID: <575911ec-aa33-4c5b-877b-8a2bdac08844@arm.com> (raw)
In-Reply-To: <20240727195752.GA30914@willie-the-truck>
On 7/28/24 01:27, Will Deacon wrote:
> On Fri, Jul 26, 2024 at 10:09:30PM +0200, Sedat Dilek wrote:
>> The COMPRESSED_INSTALL kconfig does not sound very meaningful.
>>
>> Rename from COMPRESSED_INSTALL kconfig to KERNEL_IMAGE_COMPRESSED_INSTALL.
>>
>> Fixes: commit 4c7be57f2 ("arm64: allow installing compressed image by default")
"Fixes:" tag should only be used for patches that fix real functional
problems in the code.
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>> ---
>> arch/arm64/Kconfig | 6 +++---
>> arch/arm64/Makefile | 6 +++---
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> Hmm, I'm not sure I see the point of this tbh. I think the code is fine
> as it is.
Agreed, only thing this patch does is to add "kernel image" prefix
in the config as well in related descriptions which in itself does
not make this any better. As Will mentioned, it is better to leave
this unchanged.
prev parent reply other threads:[~2024-07-29 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 20:09 Sedat Dilek
2024-07-27 19:57 ` Will Deacon
2024-07-29 2:37 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575911ec-aa33-4c5b-877b-8a2bdac08844@arm.com \
--to=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®