From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbcFINM0 (ORCPT ); Thu, 9 Jun 2016 09:12:26 -0400 Received: from mail.phytec.co.uk ([217.6.246.34]:33455 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbcFINMX (ORCPT ); Thu, 9 Jun 2016 09:12:23 -0400 Subject: Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support To: Lee Jones References: <1464850228-17244-1-git-send-email-w.egorov@phytec.de> <20160608141735.GE14888@dell> <5759277D.7090101@phytec.de> <20160609111201.GA1388@dell> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mturquette@baylibre.com, sboyd@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, dianders@chromium.org, zyw@rock-chips.com From: Wadim Egorov Message-ID: <57596B1C.2010101@phytec.de> Date: Thu, 9 Jun 2016 15:11:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160609111201.GA1388@dell> X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 09.06.2016 15:11:59, Serialize by Router on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 09.06.2016 15:11:59, Serialize complete at 09.06.2016 15:11:59 X-TNEFEvaluated: 1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.06.2016 13:12, Lee Jones wrote: > On Thu, 09 Jun 2016, Wadim Egorov wrote: >> On 08.06.2016 16:17, Lee Jones wrote: >>> On Thu, 02 Jun 2016, Wadim Egorov wrote: >>> >>>> The RK818 chip is a power management IC for multimedia and handheld >>> "Power Management IC (PMIC)" >>> >>>> devices. It contains the following components: >>>> >>>> - Regulators >>>> - RTC >>>> - Clkout >>> Clocking >>> >>>> - battery support >>> Battery support >>> >>>> Both chips RK808 and RK818 are using a similar register map. >>> "Both RK808 ad RK818 chips" >>> >>>> So we can reuse the RTC and Clkout functionality. >>> Swap '.' for ','. >>> >>>> Signed-off-by: Wadim Egorov >>>> --- >>>> drivers/mfd/Kconfig | 4 +- >>>> drivers/mfd/rk808.c | 231 ++++++++++++++++++++++++++++++++++++++-------- >>>> include/linux/mfd/rk808.h | 162 ++++++++++++++++++++++++++++++-- >>>> 3 files changed, 350 insertions(+), 47 deletions(-) > [...] > >>>> -struct rk808_reg_data { >>>> - int addr; >>>> - int mask; >>>> - int value; >>>> -}; >>> Why are you moving this to the header? >> It is now part of the rk808 struct. > Why? > For me it seemed reasonable. My idea was to have only one chip variant check. I can move the rk808_reg_data struct back to the c file, check for the chip variant within the probe function and initialize the proper reg_data variable. This would also apply to the mfd_cell variables.