mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Laxman Dewangan <ldewangan@nvidia.com>, wim@iguana.be
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH V3] watchdog: max77620: Add support for watchdog timer
Date: Thu, 9 Jun 2016 06:33:38 -0700	[thread overview]
Message-ID: <57597032.8040008@roeck-us.net> (raw)
In-Reply-To: <1465393148-24890-1-git-send-email-ldewangan@nvidia.com>

On 06/08/2016 06:39 AM, Laxman Dewangan wrote:
> Maxim PMIC MAX77620 is Power management IC which have multiple
> sub blocks like regulators (DCDC/LDOs), GPIO, RTC, Clock, Watchdog
> timer etc.
>
> Add the driver for watchdog timer under watchdog framework.
> The driver implements the watchdog callbacks to start, stop,
> ping and set timeout for watchodg framework.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

Mostly good.

[ ... ]

> +	/* Check if WDT running and ig yes then set flags properly */

s/ig/if/

Please fix this up and resend, with

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Can you by any chance send me a copy of the datasheet ? I wanted to look up the
chip default for the watchdog timeout and realized that the chip does not
officially exist.

Thanks,
Guenter

      reply	other threads:[~2016-06-09 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 13:39 Laxman Dewangan
2016-06-09 13:33 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57597032.8040008@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome