From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932281AbcFJKiM (ORCPT ); Fri, 10 Jun 2016 06:38:12 -0400 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:38265 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbcFJKiK (ORCPT ); Fri, 10 Jun 2016 06:38:10 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 1/1] Staging: comedi: dmm32at: fix BIT macro issue. To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1465473879-22017-1-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <575A988F.9060408@mev.co.uk> Date: Fri, 10 Jun 2016 11:38:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1465473879-22017-1-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/16 13:04, Ravishankar Karkala Mallikarjunayya wrote: > This Replace all occurences of (1< DMM32AT_AI_CFG(x) macros to get rid of checkpatch.pl > "CHECK" output "Prefer using the BIT macro" > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/dmm32at.c | 98 ++++++++++++++++---------------- > 1 file changed, 50 insertions(+), 48 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c > index 958c0d4..0d50105 100644 > --- a/drivers/staging/comedi/drivers/dmm32at.c > +++ b/drivers/staging/comedi/drivers/dmm32at.c [snip] > -#define DMM32AT_CTRL_RESETA (1 << 5) > -#define DMM32AT_CTRL_RESETD (1 << 4) > -#define DMM32AT_CTRL_INTRST (1 << 3) > -#define DMM32AT_CTRL_PAGE_8254 (0 << 0) > -#define DMM32AT_CTRL_PAGE_8255 (1 << 0) > -#define DMM32AT_CTRL_PAGE_CALIB (3 << 0) > +#define DMM32AT_CTRL_RESETA BIT(5) > +#define DMM32AT_CTRL_RESETD BIT(4) > +#define DMM32AT_CTRL_INTRST BIT(3) > +#define DMM32AT_CTRL(x) ((x) << 0) > +#define DMM32AT_CTRL_PAGE_8254 DMM32AT_CTRL(0) > +#define DMM32AT_CTRL_PAGE_8255 DMM32AT_CTRL(1) > +#define DMM32AT_CTRL_PAGE_CALIB DMM32AT_CTRL(3) The macro name DMM32AT_CTRL(x) is not specific enough. It should be DMM32AT_CTRL_PAGE(x) to match the names of the macros that use it (DMM32AT_CTRL_PAGE_8254 etc.). [snip] > -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4) > -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4) > -#define DMM32AT_AI_CFG_SCINT_10US (2 << 4) > -#define DMM32AT_AI_CFG_SCINT_5US (3 << 4) > -#define DMM32AT_AI_CFG_RANGE (1 << 3) /* 0=5V 1=10V */ > -#define DMM32AT_AI_CFG_ADBU (1 << 2) /* 0=bipolar 1=unipolar */ > +#define DMM32AT_AI_CFG(x) ((x) << 4) > +#define DMM32AT_AI_CFG_SCINT_20US DMM32AT_AI_CFG(0) > +#define DMM32AT_AI_CFG_SCINT_15US DMM32AT_AI_CFG(1) > +#define DMM32AT_AI_CFG_SCINT_10US DMM32AT_AI_CFG(2) > +#define DMM32AT_AI_CFG_SCINT_5US DMM32AT_AI_CFG(3) The same thing here. Please rename DMM32AT_AI_CFG(x) to DMM32AT_AI_CFG_SCINT(x). (Don't forget to update the patch description to match these changes.) -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-