From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964785AbcFMCcq (ORCPT ); Sun, 12 Jun 2016 22:32:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35330 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933106AbcFMCco (ORCPT ); Sun, 12 Jun 2016 22:32:44 -0400 Subject: Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by default To: Auger Eric , kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org References: <1464472878-27176-1-git-send-email-okaya@codeaurora.org> <1464472878-27176-7-git-send-email-okaya@codeaurora.org> Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , Alex Williamson , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <575E1B45.3070406@codeaurora.org> Date: Sun, 12 Jun 2016 22:32:37 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/7/2016 3:59 PM, Auger Eric wrote: >> - vfio_platform_get_reset(vdev); >> > + ret = vfio_platform_get_reset(vdev); >> > + if (ret && vdev->reset_required) { >> > + pr_err("vfio: no reset function found for device %s\n", >> > + vdev->name); >> > + iommu_group_put(group); >> > + return ret; > nit: in case you respin you can factorize the group put and return ret in a goto label > (since also used above). > > Besides Reviewed-by: Eric Auger thanks, done. I'll respin with your request. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project