mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zongmin Zhou <min_halo@163.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	i@zenithal.me, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, shuah@kernel.org,
	valentina.manea.m@gmail.com,
	Zongmin Zhou <zhouzongmin@kylinos.cn>
Subject: Re: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver
Date: Mon, 28 Apr 2025 17:51:08 +0800	[thread overview]
Message-ID: <575ce02c-9128-4098-a852-d9e14f14010e@163.com> (raw)
In-Reply-To: <2025042512-corsage-handpick-bf2a@gregkh>

Dear Greg and Shuah,

I found out that the vhci-hcd driver added this virtual device
as a platform device from the very beginning since 2014.
I'm just getting in touch with this module and
don't have a deep understanding of it,shuah should be clearer.

I don't know if using the faux bus to replace the platform bus can solve 
the problem
that the error limitation on max_hw_sectors for usbip device since 
commit d74ffae8b8dd applied.
But this change will request user to update kernel version to support 
faux bus.
This will also be an expensive change to fix the problem?

I have been discussing with shuah for a long time.
Is there any simpler way to fix this problem?

On 2025/4/25 16:28, Greg KH wrote:
> On Fri, Apr 25, 2025 at 04:08:47PM +0800, Zongmin Zhou wrote:
>> Dear Greg and Christoph:
>>
>> This patch is the simple solution for the issue described in below link:
>> https://lore.kernel.org/all/20250219092555.112631-1-min_halo@163.com/
>>
>> This issue has been discussed at length with Shuah.
>>
>> As Christoph said,vhci-hcd is a virtual hci,
>> but it serves as a bridge to connect virtual USB devices to the real USB
>> controller.
>> Since the commit d74ffae8b8dd is applied on kernel v5.3,
>> the virtual USB devices's max_sectors size is limited since v5.3.
>>
>> Just because on vhci-hcd, the dma mask setting follows the platform device
>> default setting(32-bit).
> Wait, why is vhci-hcd a platform device at all?  It shouldn't be doing
> that, try removing that to start with, which will remove that "default"
> setting.  I recommend using the faux bus as a potential replacement.
>
> thanks,
>
> greg k-h


  reply	other threads:[~2025-04-28  9:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19  9:25 [PATCH] usbip: Fix the error limitation on max_hw_sectors for usbip device Zongmin Zhou
2025-02-21 16:37 ` Shuah Khan
     [not found]   ` <5a41d6c3.8c78.195371996e0.Coremail.min_halo@163.com>
2025-02-27 22:23     ` Shuah Khan
     [not found]       ` <4d4035bf.26b9.19556dcc23d.Coremail.min_halo@163.com>
2025-03-04 19:45         ` Shuah Khan
     [not found]           ` <6d47fef6.9eef.19565c308e5.Coremail.min_halo@163.com>
2025-03-10 16:49             ` Shuah Khan
2025-03-13 10:02               ` Zongmin Zhou
2025-03-28 21:14                 ` Shuah Khan
2025-04-02  8:34                   ` Zongmin Zhou
2025-04-08 22:54                     ` Shuah Khan
2025-04-22  6:34                       ` [PATCH] usbip: set the dma mask to 64bit default for vhci-driver Zongmin Zhou
2025-04-22  6:40                         ` Greg KH
2025-04-22  7:24                         ` Christoph Hellwig
2025-04-25  8:08                           ` Zongmin Zhou
2025-04-25  8:28                             ` Greg KH
2025-04-28  9:51                               ` Zongmin Zhou [this message]
2025-04-28 10:04                                 ` Greg KH
2025-04-28 23:07                                   ` Shuah Khan
2025-04-30  5:24                                     ` Zongmin Zhou
2025-04-30  7:31                                       ` Greg KH
2025-04-23  1:02                         ` kernel test robot
2025-04-23  7:50                         ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575ce02c-9128-4098-a852-d9e14f14010e@163.com \
    --to=min_halo@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=i@zenithal.me \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=valentina.manea.m@gmail.com \
    --cc=zhouzongmin@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®