From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932947AbcFOOko (ORCPT ); Wed, 15 Jun 2016 10:40:44 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:37346 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435AbcFOOkn (ORCPT ); Wed, 15 Jun 2016 10:40:43 -0400 Subject: Re: select on non-existing Kconfig option CRC32C To: Andreas Ziegler , Hendrik Brueckner References: <5761275B.4010508@fau.de> Cc: Martin Schwidefsky , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel From: Randy Dunlap Message-ID: <576168E5.9020009@infradead.org> Date: Wed, 15 Jun 2016 07:40:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <5761275B.4010508@fau.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/16 03:00, Andreas Ziegler wrote: > Hi Hendrik, > > your patch "s390/crc32-vx: add crypto API module for optimized CRC-32 > algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195. > > The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. > However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. > Should I prepare a trivial patch to fix this up or would you like to do that on > your side? > > I found this issue by comparing yesterday's tree and today's tree using > 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'. or should it select CRC32 or LIBCRC32C? (probably not the LIB... one) -- ~Randy