mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Zhong Shiqi <zhong.shiqi@zte.com.cn>, cocci@systeme.lip6.fr
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Yi Wang <wang.yi59@zte.com.cn>,
	Xue Zhihong <xue.zhihong@zte.com.cn>
Subject: Re: [PATCH v2] coccicheck: support $COCCI being defined as a directory
Date: Thu, 24 Oct 2019 09:06:27 +0200	[thread overview]
Message-ID: <5762844f-2c39-2106-21fa-65e8297d4235@web.de> (raw)
In-Reply-To: <1571897060-32374-1-git-send-email-zhong.shiqi@zte.com.cn>

I find that the commit message should still be considerably improved.
How do you think about to use the subject “[PATCH] coccicheck:
Support search for SmPL scripts within selected directory hierarchy”?


> Put a modification in scripts/coccicheck which supports users in
> configuring COCCI parameter as a directory to traverse files in
> directory whose next level directory contains rule files with Suffix of cocci.

* Please avoid a typo in this change description.

* Would you like to integrate a wording approach like the following?

  A search can be performed for SmPL scripts within a directory hierarchy.
  Start a corresponding file determination if the environment variable “COCCI”
  contains an acceptable path.


Regards,
Markus

      parent reply	other threads:[~2019-10-24  7:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  6:04 [PATCH v2] coccicheck:support " zhongshiqi
2019-10-24  6:19 ` Julia Lawall
2019-10-24  7:55   ` [PATCH v2] coccicheck: support " Markus Elfring
2019-10-24  7:58     ` Julia Lawall
2019-10-24  9:11       ` [v2] " Markus Elfring
2019-10-24  7:06 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5762844f-2c39-2106-21fa-65e8297d4235@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Julia.Lawall@lip6.fr \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    --cc=yamada.masahiro@socionext.com \
    --cc=zhong.shiqi@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®