From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8106DC77B75 for ; Fri, 12 May 2023 16:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235696AbjELQ6T (ORCPT ); Fri, 12 May 2023 12:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbjELQ6N (ORCPT ); Fri, 12 May 2023 12:58:13 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86A78AD1A for ; Fri, 12 May 2023 09:58:11 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-50bc070c557so19092097a12.0 for ; Fri, 12 May 2023 09:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683910690; x=1686502690; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FrRZy7k+hmkP8Lh2Yg15UQkRzZXm3nQe96En0tZmJVk=; b=EqMoIRhrmVeXCNMWfkwK41ZjdYG/lVPlDVRRQoVS+0hToVID+a03nbL9URFXFRIXc2 T0mj1y4KoExpfH2ZdS/cPnZ4UD7ECvsw/zEKt2/lkEN42ZB3sCPDiepJHXW71otQUB/P BtChxmqWB8MQbrPApetkyW1b9R4dU84j/Ei5iXvJ5l+8ECaa9EYdAMBXpz4ZvTtI/zyf FdFhNhfbKdfyQsDTvu/glrDUiK05i5IJ50QDJ5Ng1aM8lEa66HNi3wYQicnE2iGu1m4z hZYHAdMJzOIT/iy3sOrvyggl3WNoyU5FFxELfSao7aiQoppVG4K+G7VY9QVM3mTSHidw 0A8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683910690; x=1686502690; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FrRZy7k+hmkP8Lh2Yg15UQkRzZXm3nQe96En0tZmJVk=; b=gPGJTeHFXou2PvXbotYK9eagVBGVWACcJaH9xdZkDJtQ9Gh1cvM6ajz/x5pc8ANGw+ WO3VWJiJ5liaRODBFDa6lyJ+d5D2T0eKTtQmhCZ5TPFsIdwxwEumi3BdBeXTR48Yf6Bb 0Q8yzh4blqaxkwDkgXt/fnPj4yMRyRuB6GFe3MzElVfxXU2Jh9mMwfpZvE+TEI2I+U7P +BTkVNxiwP6R6ENRSDqZLXzPpe91dp28C3ADwDWLYiulenK3gpdQQgP+3J0otRlUfb/H VeUSx5/kdhHQUr75d2tQfVi/ZfxMGt3HooT1NbTYHRSnsKYLVgvghKjIm2cZs3oqiaCI MbDA== X-Gm-Message-State: AC+VfDxbwYZ2A5An6sawYDRKKjvZ3+FFXzV2fx3aDM9cUHi7aPAf8mUn +gFo0NfXdk1OYMOR8dWL1oz3iw== X-Google-Smtp-Source: ACHHUZ4lobmym7CtlyCou9QfIUS9xOfNDTTYSye6rra7MQiJSJ/zTzraaCZsx976hm7f2OIZ1vQRMA== X-Received: by 2002:a17:907:5c5:b0:959:af74:4cf7 with SMTP id wg5-20020a17090705c500b00959af744cf7mr22337129ejb.70.1683910690031; Fri, 12 May 2023 09:58:10 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7ede:fc7b:2328:3883? ([2a02:810d:15c0:828:7ede:fc7b:2328:3883]) by smtp.gmail.com with ESMTPSA id v16-20020a170906381000b009545230e682sm5630387ejc.91.2023.05.12.09.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 09:58:09 -0700 (PDT) Message-ID: <576327d2-14e0-36fc-a758-660cdcacc340@linaro.org> Date: Fri, 12 May 2023 18:58:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 03/10] arm64: dts: qcom: qdu1000: Add properties to qfprom for multi channel DDR Content-Language: en-US To: Komal Bajaj , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230512122134.24339-1-quic_kbajaj@quicinc.com> <20230512122134.24339-4-quic_kbajaj@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230512122134.24339-4-quic_kbajaj@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2023 14:21, Komal Bajaj wrote: > Add properties to the qfprom node for multi channel DDR. > > Signed-off-by: Komal Bajaj DTS goes to the end of patchset. Better - to separate patchset with links to bindings. Subject: drop redundant pieces, it's too long without actual need. "properties to" can be skipped. > --- > arch/arm64/boot/dts/qcom/qdu1000.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi > index 734438113bba..418644f396bc 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi > +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi > @@ -1333,6 +1333,18 @@ > interrupts = ; > multi-ch-bit-off = <24 2>; > }; > + > + qfprom: efuse@221c8000 { > + compatible = "qcom,qdu1000-qfprom", "qcom,qfprom"; > + reg = <0 0x221c8000 0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + multi_chan_ddr: multi_chan_ddr@12b { No underscores in node names. Best regards, Krzysztof