mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Jean Delvare <jdelvare@suse.com>,
	Antoniu Miclaus <antoniu.miclaus@analog.com>,
	Jonathan Cameron <jic23@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (ltc2992) use fwnode_for_each_available_child_node_scoped()
Date: Wed, 22 May 2024 12:08:12 -0700	[thread overview]
Message-ID: <57645247-fb14-4180-bef0-1638e9f522fe@roeck-us.net> (raw)
In-Reply-To: <20240522-fwnode_for_each_available_child_node_scoped-v1-2-1188b0da12dc@gmail.com>

On 5/22/24 02:18, Javier Carrasco wrote:
> The error path from a zero value of the "shunt-resistor-micro-ohms"
> property does not decrement the refcount of the child node.
> 
> Instead of adding the missing fwnode_handle_put(), a safer fix for
> future modifications is using the _scoped version of the macro,
> which removes the need for fwnode_handle_put() in all error paths.
> 
> The macro defines the child node internally, which removes the need for
> the current child node declaration as well.
> 
> Fixes: 10b029020487 ("hwmon: (ltc2992) Avoid division by zero")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

I really don't like fixes which depend on an API change.

Guenter

> ---
>   drivers/hwmon/ltc2992.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
> index 229aed15d5ca..3feee400ecf8 100644
> --- a/drivers/hwmon/ltc2992.c
> +++ b/drivers/hwmon/ltc2992.c
> @@ -855,24 +855,19 @@ static const struct regmap_config ltc2992_regmap_config = {
>   static int ltc2992_parse_dt(struct ltc2992_state *st)
>   {
>   	struct fwnode_handle *fwnode;
> -	struct fwnode_handle *child;
>   	u32 addr;
>   	u32 val;
>   	int ret;
>   
>   	fwnode = dev_fwnode(&st->client->dev);
>   
> -	fwnode_for_each_available_child_node(fwnode, child) {
> +	fwnode_for_each_available_child_node_scoped(fwnode, child) {
>   		ret = fwnode_property_read_u32(child, "reg", &addr);
> -		if (ret < 0) {
> -			fwnode_handle_put(child);
> +		if (ret < 0)
>   			return ret;
> -		}
>   
> -		if (addr > 1) {
> -			fwnode_handle_put(child);
> +		if (addr > 1)
>   			return -EINVAL;
> -		}
>   
>   		ret = fwnode_property_read_u32(child, "shunt-resistor-micro-ohms", &val);
>   		if (!ret) {
> 


  parent reply	other threads:[~2024-05-22 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  9:18 [PATCH 0/2] device property: introduce fwnode_for_each_available_child_node_scoped() Javier Carrasco
2024-05-22  9:18 ` [PATCH 1/2] " Javier Carrasco
2024-05-22 11:34   ` Andy Shevchenko
2024-05-22 11:45   ` Sakari Ailus
2024-05-22  9:18 ` [PATCH 2/2] hwmon: (ltc2992) use fwnode_for_each_available_child_node_scoped() Javier Carrasco
2024-05-22 11:37   ` Andy Shevchenko
2024-05-22 19:08   ` Guenter Roeck [this message]
2024-05-22 19:46     ` Javier Carrasco
2024-05-22 22:51       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57645247-fb14-4180-bef0-1638e9f522fe@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=jic23@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®