From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596AbdAaRgu (ORCPT ); Tue, 31 Jan 2017 12:36:50 -0500 Received: from ale.deltatee.com ([207.54.116.67]:57684 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbdAaRgc (ORCPT ); Tue, 31 Jan 2017 12:36:32 -0500 To: Greg Kroah-Hartman References: <1485882204-26947-1-git-send-email-logang@deltatee.com> <1485882204-26947-2-git-send-email-logang@deltatee.com> <20170131172630.GB12595@kroah.com> Cc: Keith Busch , Myron Stowe , Bjorn Helgaas , Geert Uytterhoeven , Jonathan Corbet , "David S. Miller" , Andrew Morton , Emil Velikov , Mauro Carvalho Chehab , Guenter Roeck , Jarkko Sakkinen , Linus Walleij , Ryusuke Konishi , Stefan Berger , Wei Zhang , Kurt Schwemmer , Stephen Bates , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org From: Logan Gunthorpe Message-ID: <57658098-b24a-cb25-b2e3-ccf8fcbf8fe5@deltatee.com> Date: Tue, 31 Jan 2017 10:35:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170131172630.GB12595@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, stephen.bates@microsemi.com, kurt.schwemmer@microsemi.com, wzhang@fb.com, stefanb@linux.vnet.ibm.com, konishi.ryusuke@lab.ntt.co.jp, linus.walleij@linaro.org, jarkko.sakkinen@linux.intel.com, linux@roeck-us.net, mchehab@kernel.org, emil.l.velikov@gmail.com, akpm@linux-foundation.org, davem@davemloft.net, corbet@lwn.net, geert+renesas@glider.be, bhelgaas@google.com, myron.stowe@gmail.com, keith.busch@intel.com, gregkh@linuxfoundation.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 1/1] MicroSemi Switchtec management interface driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/01/17 10:26 AM, Greg Kroah-Hartman wrote: > That's one big patch to review, would you want to do that? Sorry, will do. > Can you break it up into smaller parts? At least put the documentation > separately, right? Ha, funny. Last time I sent a patch someone asked for the documentation to be in the same patch. But I can easily split this up. > And don't dump a .txt file into Documentation/ anymore, people are > working to move to the newer format. Fair. I wasn't sure where a good place to put it was. Any suggestions? > Also, please rebase against Linus's tree at the least, we can't go back > in time and apply this to the 4.9 kernel tree. Will do. > Why a .h file for a single .c file? I wanted to keep the hardware defining structs and macros in a separate file for future expansion. This hardware is also capable of some NTB functions which may find it's way into the kernel in the future. > Also, why a whole new directory? We didn't feel it fit in the pci director which was for standard pci stuff. We're more than open to other suggestions as to where this code belongs. Thanks, Logan