From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbcFRSUZ (ORCPT ); Sat, 18 Jun 2016 14:20:25 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751579AbcFRSUY (ORCPT ); Sat, 18 Jun 2016 14:20:24 -0400 Subject: Re: ubifs: regression: unable to mount ubifs To: Hauke Mehrtens , viro@zeniv.linux.org.uk, Artem Bityutskiy , David Woodhouse , Brian Norris References: <7158a3b3-5dee-48a0-339a-d8bcdb5b8805@hauke-m.de> Cc: MTD Maling List , LKML From: Richard Weinberger Message-ID: <576590E3.2090603@nod.at> Date: Sat, 18 Jun 2016 20:20:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <7158a3b3-5dee-48a0-339a-d8bcdb5b8805@hauke-m.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Am 18.06.2016 um 20:19 schrieb Hauke Mehrtens: > The commit 322ea0bb "mtd: switch ubi_open_volume_path() to vfs_stat()" > breaks mounting ubifs volumes for me. > > On kernel 4.7-rc3 I am getting the following error when trying to mount > an ubifs volume. This volume in on a ubi file system which exports it as > a mtd partition. > > root@lede:/# mkdir /tmp/test > root@lede:/# mount -t ubifs /dev/ubi0_10 /tmp/test/ > [ 178.782184] UBIFS error (pid: 955): cannot open "/dev/ubi0_10", error > -22mount: mounting /dev/ubi0_10 on /tmp/test/ failed: Invalid argument > root@lede:/# > > In the function ubi_open_volume_path() the call to vfs_stat() returns > -EFAULT. > > After I reverted commit 322ea0bb it works again. Fixes for this are already in Linus' tree and will be part of -rc4. :-) Thanks, //richard