From: Florian Fainelli <florian.fainelli@broadcom.com>
To: shao.mingyin@zte.com.cn, linusw@kernel.org, brgl@kernel.org,
linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, geert+renesas@glider.be,
andrew@codeconstruct.com.au, wbg@kernel.org, opendmb@gmail.com,
bcm-kernel-feedback-list@broadcom.com, jelonek.jonas@gmail.com
Subject: Re: [PATCH 4/5] gpio: brcmstb: don't turn platform_get_irq errors into -ENOENT
Date: Mon, 9 Nov 2026 20:39:29 -0800 [thread overview]
Message-ID: <5766e56e-b98d-4df8-9378-4efc078ef1e8@broadcom.com> (raw)
In-Reply-To: <20261107161256805UKbBUjg-wlWpCWzE2fBjl@zte.com.cn>
On 11/7/2026 12:12 AM, shao.mingyin@zte.com.cn wrote:
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>
> When the "interrupt-controller" property is present, brcmstb_gpio_probe()
> maps any platform_get_irq() failure to -ENOENT. This swallows
> -EPROBE_DEFER (the parent interrupt controller may not be probed yet),
> so the device never gets retried and the GPIO controller is permanently
> unavailable. Return the original error code instead.
>
> Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2026-11-10 4:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 8:12 [PATCH 0/5] gpio: fix IRQ handling and probe error paths in five drivers shao.mingyin
2026-11-07 8:12 ` [PATCH 1/5] gpio: rcar: don't clobber INTMSK when disabling a single line shao.mingyin
2026-11-09 14:40 ` Geert Uytterhoeven
2026-11-09 14:57 ` shao.mingyin
2026-11-07 8:12 ` [PATCH 2/5] gpio: aspeed-sgpio: propagate IRQ setup error in probe shao.mingyin
2026-11-09 3:55 ` Andrew Jeffery
2026-11-07 8:12 ` [PATCH 3/5] gpio: 104-idi-48: fix max_register blocking the IRQ register shao.mingyin
2026-11-07 20:19 ` William Breathitt Gray
2026-11-07 8:12 ` [PATCH 4/5] gpio: brcmstb: don't turn platform_get_irq errors into -ENOENT shao.mingyin
2026-11-10 4:39 ` Florian Fainelli [this message]
2026-11-07 8:12 ` [PATCH 5/5] gpio: line-mux: fix unsigned truncation of property count error shao.mingyin
2026-11-09 8:29 ` Jonas Jelonek
2026-11-09 10:21 ` shao.mingyin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5766e56e-b98d-4df8-9378-4efc078ef1e8@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@codeconstruct.com.au \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@kernel.org \
--cc=geert+renesas@glider.be \
--cc=jelonek.jonas@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=shao.mingyin@zte.com.cn \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®