From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932512AbcFUHMI (ORCPT ); Tue, 21 Jun 2016 03:12:08 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:16902 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbcFUHLp (ORCPT ); Tue, 21 Jun 2016 03:11:45 -0400 X-AuditID: cbfec7f4-f796c6d000001486-ba-5768e817a28c Message-id: <5768E815.5080706@samsung.com> Date: Tue, 21 Jun 2016 09:09:09 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: "Andrew F. Davis" Cc: Russell King , Miguel Ojeda Sandonis , Linus Walleij , Sebastian Reichel , Wolfram Sang , Richard Purdie , Rusty Russell , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Ulf Hansson , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , Ingo Molnar , linux-pwm@vger.kernel.org, lguest@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled References: <20160613200211.14790-1-afd@ti.com> <20160613200211.14790-13-afd@ti.com> <5760FA52.7010806@samsung.com> <57647DBD.2010406@ti.com> <57679E38.3080901@samsung.com> <57686A94.2010704@ti.com> In-reply-to: <57686A94.2010704@ti.com> Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA03RW0iTYRzHcZ+9x5mrtznz0aJykBeCmlDyFBJ594JQCoERlE59c+KmY5ui 0YXEpNTBkqzV8FAOycOc5zwWNNJNJ+gyRUUnhorl1EJD8zBzjsC7D8//C7+Lh8aETjyYzshS c8osiUxM+uJ2t3U8PHBZmnh5/JsQrQ+VUsjY6cTRryeFGPpgLMPQotuOobK99zzUVrUH0LP9 TYDGespJ1OEyA6Rt7iDQlwMdQLOz9QC5amcoZHn5EaDdLTeBGpby0JTeRaEG9xBAvT2LBJp6 NYojewmB7L1qZG1MRHU2A3YziB2bcGBst2GWYrUuDcG21heR7MxEH8lWDiawI6/fAbbizQ7J tusOi76qbYKtbbZh7ODQAs5aJzt57Ebr+fiT93xj0jhZRi6njLyR7Cud3izlKXR+eeZpDVUA 9PxiwKchcwXWtk+SXp+Bo86mQ/vSQqYGwAO9g/AchMwSgIbhEI8FTBgsts0Bj3HmEtyZs+Ee k0wU/Lu8wvM4gLkL9+yfCG9/Gm6/cB41IkYMCwZLCM8AxugoqPnx+yjyZx5A/a4e944NAzja SnnMZ0Lhhnb+qMGYaPhdY8a8vgDbTKvYc8AYjm0YjmWGY9lbgNWDAC4nVaFKSZdHRagkclVO VnpEara8FXh/fbMLGAeuWwBDA7Gf4GKkNFFISHJV+XILgDQmFgnilg6fBGmS/EecMjtJmSPj VBZwlsbFgYKKnvU7QiZdouYyOU7BKf9feTQ/uABcnV4ggpODVjtbMuOiQD/6Q/0USSlt07q6 MjamL2zGp+prXbzJ2EhXJ86byYEaWL0li81tfvywn8zt2o4+kfHUqhWbJjjFZ0f4qSK13HbO VJi3NrLi2O8O8ieSBgqvOVJCCm6XD9f03E9PCBXdquCHtvjUDuxY1lyduLtEjKukkqgwTKmS /APYfnzF8QIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, This patch doesn't apply, please rebase onto recent LED tree. On 06/21/2016 12:13 AM, Andrew F. Davis wrote: > Some systems use 'gpio_led_register_device' to make an in-memory copy of > their LED device table so the original can be removed as .init.rodata. > When the LED subsystem is not enabled source in the led directory is not > built and so this function may be undefined. Fix this here. > > Signed-off-by: Andrew F. Davis > --- > include/linux/leds.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/leds.h b/include/linux/leds.h > index d2b1306..a4a3da6 100644 > --- a/include/linux/leds.h > +++ b/include/linux/leds.h > @@ -386,8 +386,16 @@ struct gpio_led_platform_data { > unsigned long *delay_off); Currently there is some stuff here, and in fact it has been for a long time. Patch "[PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS is set" also doesn't apply. What repository are you using? > }; > > +#ifdef CONFIG_NEW_LEDS > struct platform_device *gpio_led_register_device( > int id, const struct gpio_led_platform_data *pdata); > +#else > +static inline struct platform_device *gpio_led_register_device( > + int id, const struct gpio_led_platform_data *pdata) > +{ > + return 0; > +} > +#endif > > enum cpu_led_event { > CPU_LED_IDLE_START, /* CPU enters idle */ > -- Best regards, Jacek Anaszewski