From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752496AbcFVLYq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 07:24:46 -0400
Received: from mail.yifangdigital.com ([121.15.200.100]:4866 "EHLO
	yifangdigital.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751077AbcFVLYW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 07:24:22 -0400
Subject: Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown
To: Jiri Kosina <jikos@kernel.org>
References: <1466504865-19907-1-git-send-email-ghzhong@yifangdigital.com>
 <alpine.LNX.2.00.1606211308590.6874@cbobk.fhfr.pm>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Dmitry Torokhov <dtor@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Andrew Duggan <aduggan@synaptics.com>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: ghzhong <ghzhong@yifangdigital.com>
Message-ID: <576A7367.8040904@yifangdigital.com>
Date: Wed, 22 Jun 2016 19:15:51 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.00.1606211308590.6874@cbobk.fhfr.pm>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: ghzhong@yifangdigital.com
X-Spam-Processed: yifangdigital.com, Wed, 22 Jun 2016 19:16:51 +0800
	(not processed: message from valid local sender)
X-MDRemoteIP: 192.168.0.9
X-Return-Path: ghzhong@yifangdigital.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 06/21/2016 07:09 PM, Jiri Kosina wrote:
> On Tue, 21 Jun 2016, Guohua Zhong wrote:
>
>> Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free
>> irq before device shutdown.
>>
>> Some HW design (i.e. Umaro, a chromebook model) is that the power to
>> i2c hid device won't down after device shutdown. Also the i2c-hid driver
>> do not send suspend cmd to the hid i2c device and free its irq before
>> shutdown.So if We touch the touchscreen or some other i2c hid device,
>> the power consumtion will be go up even when the device is in shutdown
>> state.
>>
>> Though the root cause maybe a HW issue. But it seems that it is a
>> good pratice to set power sleep for i2c-hid device before shutdown.
> Applied, thanks.
>
Do you mean that the Patch V2 has been reviewed & approved? Or I make something wrong and need  to do something else?