mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set
Date: Sat, 25 Jun 2016 01:02:39 +0300	[thread overview]
Message-ID: <576DADFF.3040206@mentor.com> (raw)
In-Reply-To: <1466756938.30123.272.camel@linux.intel.com>

On 24.06.2016 11:28, Andy Shevchenko wrote:
> On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote:
>> If kernel build configuration has enabled CONFIG_PM and unset
>> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not
>> be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro
>> declaration:
>>
>>   drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier
>> 'INTEL_LPSS_SLEEP_PM_OPS'
>>   drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’
>> undeclared here (not in a function)
> 
> And may I ask what ancient kernel you are using?
> 
> commit 47b91923ea41288751e83a5b080576085a831333
> Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date:   Mon Sep 14 11:32:47 2015 +0300
> 
>     mfd: intel-lpss: Fix build error when !CONFIG_PM_SLEEP

The original driver was backported to 4.1

Thanks for the reference to a fixup, I'll backport it as well.

Lee, please ignore this change.

--
With best wishes,
Vladimir

      reply	other threads:[~2016-06-24 22:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  0:11 Vladimir Zapolskiy
2016-06-24  0:13 ` Vladimir Zapolskiy
2016-06-24  8:28 ` Andy Shevchenko
2016-06-24 22:02   ` Vladimir Zapolskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576DADFF.3040206@mentor.com \
    --to=vladimir_zapolskiy@mentor.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®