From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA495C2BA19 for ; Thu, 9 Apr 2020 21:42:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6744206F7 for ; Thu, 9 Apr 2020 21:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727074AbgDIVmn (ORCPT ); Thu, 9 Apr 2020 17:42:43 -0400 Received: from smtprelay0228.hostedemail.com ([216.40.44.228]:47544 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726638AbgDIVmm (ORCPT ); Thu, 9 Apr 2020 17:42:42 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 2E3DD182CCCD2; Thu, 9 Apr 2020 21:42:42 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wax82_51ab01c676e4b X-Filterd-Recvd-Size: 2471 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Thu, 9 Apr 2020 21:42:41 +0000 (UTC) Message-ID: <576a57b4c134903e9889cb670ccbb08a47230b6c.camel@perches.com> Subject: Re: [PATCH] checkpatch: check for missing \n at the end of logging message From: Joe Perches To: Christophe JAILLET , apw@canonical.com, Andrew Morton Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Thu, 09 Apr 2020 14:40:40 -0700 In-Reply-To: <59d1ef8f-4fb0-9af2-f761-b52559c8a699@wanadoo.fr> References: <20200407204908.10420-1-christophe.jaillet@wanadoo.fr> <8617a6b94c0644bce1fd4ca77309d67a612e6300.camel@perches.com> <4b7e1cf3-6fa7-60af-a1d3-2457339dbe8a@wanadoo.fr> <60c732a1-aa4e-afab-d223-894a67713003@wanadoo.fr> <05379b22-6755-368b-8127-8827fa020189@wanadoo.fr> <59d1ef8f-4fb0-9af2-f761-b52559c8a699@wanadoo.fr> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-04-09 at 20:52 +0200, Christophe JAILLET wrote: > In fact, I don't really see the need to modify many files just for some > kind of style. > (same reason why I think that checkpatch is a better place for a test > than submitting hundreds of patches based on coccinelle) > > From your point of view, does auditing and fixing these missing \n make > sense? Not all that much no. Even the existing conversions of formats missing newlines isn't all that important. It's only a consideration for relatively unmaintained old drivers and arches that still use printk without a KERN_ where a message might either be interleaved with a pr_ style message without a terminating newline or by old style messages that should actually instead be coalesced because the printks don't have any KERN_. > Wouldn't it just be a lot of noise for a small benefit? Much of the noise has already been filtered out by patches and the ambient noise is already at a relatively low level. Quiet is good though and I think the noise reduction is useful and quite painless.