From: Andrew Lunn <andrew@lunn.ch>
To: Aleksei Sviridkin <f@lex.la>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: phy: restore the interrupt after a generic-driver bind cycle
Date: Thu, 27 Aug 2026 20:09:54 +0200 [thread overview]
Message-ID: <576ee16b-407d-4cc4-b5bf-67843fa16f62@lunn.ch> (raw)
In-Reply-To: <20260824024029.41310-3-f@lex.la>
> Take it back from the MDIO bus interrupt table on both exits from the
> cycle: the cycle does not touch that table, so whatever the bus
> recorded there still stands. A bus that never filled it has nothing to
> give back and its PHY stays polled.
Bit of an odd phrase.
It might be better to explain that mdiobus_alloc() defaults to filling
bus->irq[] for polling.
> +static void phy_restore_genphy_irq(struct phy_device *phydev)
> +{
> + if (phydev->irq == PHY_POLL)
> + phydev->irq = phydev->mdio.bus->irq[phydev->mdio.addr];
Why conditional? Maybe it is buried deep in that wall of text?
Andrew
prev parent reply other threads:[~2026-08-27 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 2:40 [PATCH net-next v2 0/2] net: fix a stale phylink PHY pointer and a lost PHY interrupt Aleksei Sviridkin
2026-08-24 2:40 ` [PATCH net-next v2 1/2] net: phylink: unwind the PHY binding when bringup fails late Aleksei Sviridkin
2026-08-27 18:04 ` Andrew Lunn
2026-08-24 2:40 ` [PATCH net-next v2 2/2] net: phy: restore the interrupt after a generic-driver bind cycle Aleksei Sviridkin
2026-08-27 13:28 ` Paolo Abeni
2026-08-27 18:09 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576ee16b-407d-4cc4-b5bf-67843fa16f62@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f@lex.la \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®