From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F38E93DE420 for ; Thu, 16 Apr 2026 15:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776351983; cv=none; b=R8zvOGRNHgnQ++EI6+o0d63kudVVLq9YZ8Vz9lK/ljy78UKCjFBFMDI8/h7aznki0fojD6XCNG+MbykaVEZzNQDsz9S2CyE+fj2Y4JiaFdKmJCPHPfcfLUp9du7lb3CTWfBSccxdW1UvauP48cwf4fZddRrR3ti3Svji2ryF5i8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776351983; c=relaxed/simple; bh=Ol1goJZDgrWsTReQ7HSw0cZ1oRgrRxbsQKkqfyxS378=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oPOs5gPgAphC+oRn4lINiIN5Zg+4JGlzTpLR8B3RBjYs2zyZ/XqVXSXgtqabsWq4GgbkyLh+wOCEsFvLm1aoW4rnDyNPwzOqDQLp6HzuM0tVlZK3JqEb8C2vZrMXZyaxEwaYhC47I9hwtvs4iOJVYV7oJlchWuorcS/i89PiASQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bnr0MSVp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bnr0MSVp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776351981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=skTeBJyUryUUB/sfZyiJo4rCpAWd992OL8ZYFv1fHbA=; b=bnr0MSVpX7c9B+mvM63jJ2U4k/6dvHDiaGnsllKVYZGfaK34rYjFiGKVYUD7WQh9g2qwIZ OBZ6NZ2dIrLs09RsrkIptI1SLwsQkaGm6v0NwoPSUq/5B7Yb/lJbs+NfKfQDfgCvmz/XYX GH5NqX3aAZQsH5m+mEawZ1xU5WJEbHU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-SSCOntd2P_qf5-LWU_L_YQ-1; Thu, 16 Apr 2026 11:06:17 -0400 X-MC-Unique: SSCOntd2P_qf5-LWU_L_YQ-1 X-Mimecast-MFC-AGG-ID: SSCOntd2P_qf5-LWU_L_YQ_1776351976 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3381C18002CA; Thu, 16 Apr 2026 15:06:16 +0000 (UTC) Received: from [10.17.17.49] (unknown [10.17.17.49]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3D1EF30001A4; Thu, 16 Apr 2026 15:06:15 +0000 (UTC) Message-ID: <577015a8-4506-475e-99a7-3eb28f4341db@redhat.com> Date: Thu, 16 Apr 2026 11:06:14 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] locking: fix typos in comments To: Xiang Gao , peterz@infradead.org, mingo@redhat.com, will@kernel.org, boqun@kernel.org Cc: linux-kernel@vger.kernel.org, Xiang Gao References: <20260416090407.930301-1-gxxa03070307@gmail.com> Content-Language: en-US From: Waiman Long In-Reply-To: <20260416090407.930301-1-gxxa03070307@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 4/16/26 5:04 AM, Xiang Gao wrote: > From: Xiang Gao > > Fix the following typos in comments: > > mutex.c: "crital" -> "critical" (2 instances) > mutex.c: "task_strcut" -> "task_struct" (2 instances) > rwsem.c: "Otherwisee" -> "Otherwise" > rwsem.c: "crital" -> "critical" (2 instances) > rwsem.c: "task_strcut" -> "task_struct" > > Signed-off-by: Xiang Gao > --- > kernel/locking/mutex.c | 6 +++--- > kernel/locking/rwsem.c | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c > index 186b463fe326..658cebc0958d 100644 > --- a/kernel/locking/mutex.c > +++ b/kernel/locking/mutex.c > @@ -380,8 +380,8 @@ bool mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner, > * Ensure we emit the owner->on_cpu, dereference _after_ > * checking lock->owner still matches owner. And we already > * disabled preemption which is equal to the RCU read-side > - * crital section in optimistic spinning code. Thus the > - * task_strcut structure won't go away during the spinning > + * critical section in optimistic spinning code. Thus the > + * task_struct structure won't go away during the spinning > * period > */ > barrier(); > @@ -420,7 +420,7 @@ static inline int mutex_can_spin_on_owner(struct mutex *lock) > > /* > * We already disabled preemption which is equal to the RCU read-side > - * crital section in optimistic spinning code. Thus the task_strcut > + * critical section in optimistic spinning code. Thus the task_struct > * structure won't go away during the spinning period. > */ > owner = __mutex_owner(lock); > diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c > index bf647097369c..016d69053ce4 100644 > --- a/kernel/locking/rwsem.c > +++ b/kernel/locking/rwsem.c > @@ -638,7 +638,7 @@ static inline bool rwsem_try_write_lock(struct rw_semaphore *sem, > if (has_handoff) { > /* > * Honor handoff bit and yield only when the first > - * waiter is the one that set it. Otherwisee, we > + * waiter is the one that set it. Otherwise, we > * still try to acquire the rwsem. > */ > if (first->handoff_set && (waiter != first)) > @@ -737,8 +737,8 @@ static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem) > } > > /* > - * Disable preemption is equal to the RCU read-side crital section, > - * thus the task_strcut structure won't go away. > + * Disable preemption is equal to the RCU read-side critical section, > + * thus the task_struct structure won't go away. > */ > owner = rwsem_owner_flags(sem, &flags); > /* > @@ -796,7 +796,7 @@ rwsem_spin_on_owner(struct rw_semaphore *sem) > * checking sem->owner still matches owner, if that fails, > * owner might point to free()d memory, if it still matches, > * our spinning context already disabled preemption which is > - * equal to RCU read-side crital section ensures the memory > + * equal to RCU read-side critical section ensures the memory > * stays valid. > */ > barrier(); Acked-by: Waiman Long