From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbcF0C1b (ORCPT ); Sun, 26 Jun 2016 22:27:31 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33232 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbcF0C13 (ORCPT ); Sun, 26 Jun 2016 22:27:29 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79266d000001428-9c-57708f0804a3 Content-transfer-encoding: 8BIT Message-id: <57708F07.1010008@samsung.com> Date: Mon, 27 Jun 2016 11:27:19 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Paul Gortmaker , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Kyungmin Park , linux-pm@vger.kernel.org Subject: Re: [PATCH 1/5] PM / devfreq: make devfreq explicitly non-modular References: <20160625184351.5045-1-paul.gortmaker@windriver.com> <20160625184351.5045-2-paul.gortmaker@windriver.com> In-reply-to: <20160625184351.5045-2-paul.gortmaker@windriver.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42JZI2JSqMvRXxBu8OERq8XZpjfsFpd3zWGz +Nx7hNHiduMKNotre48zO7B69G1ZxejxeZOcx/otW5kCmKO4bFJSczLLUov07RK4MprXXmQp uMNZ8XjWU6YGxpfsXYycHBICJhI/uq5B2WISF+6tZ+ti5OIQEljBKHHq9002mKIN9x+ygthC AksZJb7NKwexeQUEJX5MvsfSxcjBwSwgL3HkUjZImFlAXWLSvEXMEHMeMEp0/F/HBFGvJXHh 0SQwm0VAVeJT5wlGEJsNKL7/xQ02kDmiAhES3ScqQcIiAv4S2zesYYeYWSRxdft9sFZhAS+J y68OMkGcc5pRYsnbWhCbU8BRorOhjQVkr4TAJnaJt/8vsUDsEpD4NvkQ2J0SArISmw4wQ7wl KXFwxQ2WCYxis5B8Mwvhm1lIvlnAyLyKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIzCSTv97 1reD8eYB60OMAhyMSjy8F2QKwoVYE8uKK3MPMZoCHTGRWUo0OR8Yr3kl8YbGZkYWpiamxkbm lmZK4rwJUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTDO+mP5V6pp66Ln9b/7jyt+0X9Y JtZnILHzz1yNLeIL1pxTNm5jzs12ZJhhPvHF1juXWBK+zdh9qljm8R4Wo4kzNtu/Xpzt/HHf zLJ7XzfHXpX62HW8tr3YffLRvtuJx7IE+K/xGl//smzulvsnXpYJtbRucxXpLkmeObEh9djM D/a59ktleCo4lViKMxINtZiLihMBGAKFpJ8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jAV2O/oJwg9V1Fmeb3rBbXN41h83i c+8RRovbjSvYLK7tPc7swOrRt2UVo8fnTXIe67dsZQpgjmpgtMlITUxJLVJIzUvOT8nMS7dV 8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBWqmkUJaYUwoUCkgsLlbSt8M0ITTETdcC pjFC1zckCK7HyAANJKxhzGhee5Gl4A5nxeNZT5kaGF+ydzFyckgImEhsuP+QFcIWk7hwbz0b iC0ksJRR4tu8chCbV0BQ4sfkeyxdjBwczALyEkcuZYOEmQXUJSbNW8TcxcgFVP6AUaLj/zom iHotiQuPJoHZLAKqEp86TzCC2GxA8f0vbrCBzBEViJDoPlEJEhYR8JfYvmENO8TMIomr2++D tQoLeElcfnWQCeKc04wSS97WgticAo4SnQ1tLBMYBWYhuW4WwnWzkFy3gJF5FaNEakFyQXFS eq5RXmq5XnFibnFpXrpecn7uJkZwrD6T3sF4eJf7IUYBDkYlHl4N+YJwIdbEsuLK3EOMEhzM SiK8at1AId6UxMqq1KL8+KLSnNTiQ4ymQO9NZJYSTc4HppG8knhDYxMzI0sjc0MLI2NzJXHe x//XhQkJpCeWpGanphakFsH0MXFwSjUwps/J1zByPz+vt6Vy4iF+RYEJl1esfz1B1G7W1z1L g/7IiBxoLZpuvC9rZ8AbvxuPG/a09Uu3/jwdHnBrmrKfdmjhQR4NW+PsDc7xqlG1Zr+uPzHX SkkQT9v1r+C4Nst09fRj95nreFsMP99knZFZlXROqUJr3W2NBbU/GwKW/p0XZiOgp6SpxFKc kWioxVxUnAgA4qhCrOsCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 2016년 06월 26일 03:43, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > menuconfig PM_DEVFREQ > bool "Generic Dynamic Voltage and Frequency Scaling (DVFS) support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > This code wasn't using module_init, so we don't need to be concerned > with altering the initcall level here. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > We don't replace module.h with init.h since the file already has that. > But we do add export.h since this file does export some symbols. > > Cc: MyungJoo Ham > Cc: Kyungmin Park > Cc: linux-pm@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/devfreq/devfreq.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Chanwoo Choi Regards, Chanwoo Choi